Re: RFR: 8274137: TableView scrollbar/header misaligned when reloading data [v3]

2021-10-07 Thread Ajit Ghaisas
On Wed, 6 Oct 2021 12:22:54 GMT, Robert Lichtenberger wrote: > Ist there anything left for me to do? IIRC someone must now /sponsor this > change and then I can /integrate it, right? This PR needs two review approvals; currently it has one. We shall wait for @kevinrushforth to review and

Re: Proof of concept for fluent bindings for ObservableValue

2021-10-07 Thread John Hendrikx
Nir, I've created a new branch which contains all the changes which we've discussed so far. It contains JUnit 4 tests (in backported form), and a reduced API. However, the changes made in the sandbox did not fully compile due to package restrictions, and I had to make a bit more API

Integrated: 8272870: Add convenience factory methods for border and background

2021-10-07 Thread Nir Lisker
On Tue, 24 Aug 2021 16:29:11 GMT, Nir Lisker wrote: > Added convenience factory factory methods for Background and Border. This pull request has now been integrated. Changeset: bb73d43b Author:Nir Lisker URL:

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-10-07 Thread Christian Stein
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Add module version to `graphics` and `web` project's compiler

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit

2021-10-07 Thread Marius Hanl
On Wed, 6 Oct 2021 15:34:14 GMT, Jeanette Winzenburg wrote: > > Interesting, I just saw that it worked before because of the > > TableCellBehavior (edit method). Does this mean this can be removed from > > the behaviour in future? > > hmm .. the behavior talks directly to the control (not

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit

2021-10-07 Thread Marius Hanl
On Tue, 5 Oct 2021 13:18:07 GMT, Jeanette Winzenburg wrote: > cell startEdit is supposed to update the editing location on its associated > control - was done in ListCell, not in Tree-/TableCell nor TreeCell. > > Fix was to add control.edit(..). Note that ListCell was also touched to use >

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit

2021-10-07 Thread Jeanette Winzenburg
On Wed, 6 Oct 2021 15:34:14 GMT, Jeanette Winzenburg wrote: > > > Interesting, I just saw that it worked before because of the > > TableCellBehavior (edit method). Does this mean this can be removed from > > the behaviour in future? > > hmm .. the behavior talks directly to the control (not