Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v2]

2021-11-22 Thread Michael Strauß
> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype > specified for images encoded in data URIs. This should be improved as follows: > > 1. If the specified image subtype is not supported, an exception will be > thrown. > 2. If the specified image subtype is supported,

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v6]

2021-11-22 Thread John Neffenger
On Mon, 22 Nov 2021 06:43:30 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]

2021-11-22 Thread Kevin Rushforth
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]

2021-11-22 Thread Kevin Rushforth
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-11-22 Thread John Neffenger
On Sat, 18 Sep 2021 15:15:10 GMT, Kevin Rushforth wrote: > I did a CI build yesterday and again today on all three platforms and > compared the sdk between the two builds for each platform. On all three > platforms the results are the same: All files were identical except the > native

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v5]

2021-11-22 Thread John Neffenger
On Fri, 17 Sep 2021 22:10:41 GMT, Kevin Rushforth wrote: >> John Neffenger has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains seven commits: >> >> - Make build of SDK ZIP bundle reproducible >> - Merge branch 'master' into

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-11-22 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

RFR: 8277572: Image class documentation incorrect for images encoded in data URIs

2021-11-22 Thread Michael Strauß
The javadoc of `javafx.scene.image.Image` incorrectly states: 94* If a URL uses the "data" scheme, the data must be base64-encoded 95* and the MIME type must either be empty or a subtype of the 96* {@code image} type. However, omitting the MIME type of a data URI is

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-22 Thread Michael Strauß
On Mon, 22 Nov 2021 15:55:03 GMT, Abhinay Agarwal wrote: >> the for-loop is certainly faster and would allocate less memory - i find the >> `for(int i = 0, max = size())`-style a bit odd > > I could move `int max = size();` outside the loop But why? The initialization block of a `for`

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-22 Thread Abhinay Agarwal
On Thu, 18 Nov 2021 08:53:07 GMT, Marius Hanl wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the number

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-22 Thread Abhinay Agarwal
On Thu, 18 Nov 2021 00:54:30 GMT, Nir Lisker wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the number

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-22 Thread Abhinay Agarwal
On Thu, 18 Nov 2021 09:06:08 GMT, Tom Schindl wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ReadOnlyUnbackedObservableList.java >> line 119: >> >>> 117: Object obj = get(i); >>> 118: if (o.equals(obj)) return i; >>> 119: } >> >>

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v2]

2021-11-22 Thread Marius Hanl
> When a divider is moved via drag or code it will call **requestLayout()** for > the **SplitPane**. > While this is fine, it is also called when the > **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider. > > This makes no sense since we are currently layouting everything,

Re: RFR: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound [v3]

2021-11-22 Thread Abhinay Agarwal
> PathElements were skipped in AreaChart if the data point were outside axis > bounds and had duplicate value for either x or y. This is now fixed with this > PR. Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Update line

Re: RFR: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound [v2]

2021-11-22 Thread Abhinay Agarwal
On Wed, 17 Nov 2021 10:07:37 GMT, Ajit Ghaisas wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix condition and add more tests > >

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]

2021-11-22 Thread John Hendrikx
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests > still work. Also added a single JUnit 5 tests, and confirmed it works. > > I've updated the Eclipse project file for the base module only. John Hendrikx has updated the pull request incrementally with two

Re: RFR: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound [v2]

2021-11-22 Thread Abhinay Agarwal
> PathElements were skipped in AreaChart if the data point were outside axis > bounds and had duplicate value for either x or y. This is now fixed with this > PR. Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Fix condition and

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v7]

2021-11-22 Thread John Hendrikx
On Mon, 22 Nov 2021 12:52:10 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add trivial assert to JUnit5Test >> - Add explicit dependencies in build.gradle > >

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v8]

2021-11-22 Thread John Hendrikx
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests > still work. Also added a single JUnit 5 tests, and confirmed it works. > > I've updated the Eclipse project file for the base module only. John Hendrikx has updated the pull request incrementally with one

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v7]

2021-11-22 Thread Kevin Rushforth
On Sun, 21 Nov 2021 21:50:36 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John

Re: RFR: 8274274: Update JUnit to version 5.8.1 [v7]

2021-11-22 Thread Kevin Rushforth
On Sun, 21 Nov 2021 21:50:36 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John

Integrated: 8276174: JavaFX build fails on macOS aarch64

2021-11-22 Thread Andreas Heger
On Thu, 11 Nov 2021 10:46:26 GMT, Andreas Heger wrote: > By changing the value for the clang -arch parameter to "arm64", the jfx > project compiles on an apple silicon system. Are there any side effects which > I might be missing in this simple solution? This pull request has now been