Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v5]

2021-12-16 Thread Martin Fox
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as > expected by more accurately mapping from a Mac key code to a Java key code > based on the user’s active keyboard layout (the existing code assumes a US > QWERTY layout). The new code first identifies a set of Mac keys

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v5]

2021-12-16 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2021-12-16 Thread Kevin Rushforth
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v4]

2021-12-16 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-12-16 Thread Kevin Rushforth
On Thu, 16 Dec 2021 21:08:49 GMT, Martin Fox wrote: > I can't build this branch anymore, something related to compiling > CCTaskGroovy. I think I need to merge or rebase to the latest version of > master. Which is preferred, merge or rebase? Merge, please. - PR:

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-12-16 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v2]

2021-12-16 Thread Martin Fox
> The algorithm in `KeyCharacterCombination.match` relies on the call > `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It > defies the way most keyboard API’s work and no platform has got it right yet. > In particular the Mac and Linux implementations have to resort to a

Integrated: 8278905 JavaFX: EnumConverter has a typo in the toString method

2021-12-16 Thread Florian Kirmaier
On Thu, 16 Dec 2021 14:29:21 GMT, Florian Kirmaier wrote: > Fixing typo in EnumConverter This pull request has now been integrated. Changeset: 4c5bf44e Author:Florian Kirmaier Committer: Kevin Rushforth URL:

Scene builder crash in IntelliJ 2021.3 and JDK 17.0.1

2021-12-16 Thread Davide Perini
As title. Using IntelliJ 2021.3 and JDK 17.0.1 with JavaFX 17.0.1. As soon as I open an .fxml it ask me to install scene builder, I installed it and now Intellij crashes as soon as I open an fxml. Any idea? Thanks Davide

Re: RFR: 8278905 JavaFX: EnumConverter has a typo in the toString method

2021-12-16 Thread Kevin Rushforth
On Thu, 16 Dec 2021 14:29:21 GMT, Florian Kirmaier wrote: > Fixing typo in EnumConverter Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/697

RFR: 8278905 JavaFX: EnumConverter has a typo in the toString method

2021-12-16 Thread Florian Kirmaier
Fixing typo in EnumConverter - Commit messages: - 8278905 Changes: https://git.openjdk.java.net/jfx/pull/697/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=697=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278905 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1

Integrated: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)

2021-12-16 Thread Jeanette Winzenburg
On Thu, 9 Dec 2021 12:43:54 GMT, Jeanette Winzenburg wrote: > Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. This pull request has now been integrated. Changeset: 002d4f57 Author:Jeanette

Re: RFR: 8278860: Streamline properties for Monocle

2021-12-16 Thread Kevin Rushforth
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote: > Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place where the property

Integrated: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-16 Thread Kevin Rushforth
On Wed, 15 Dec 2021 00:25:08 GMT, Kevin Rushforth wrote: > Build change to strip the non-global symbols from native shared libraries on > Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` > build. > > Here is a before / after size comparison. All sizes in KBytes: > >

Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]

2021-12-16 Thread Ajit Ghaisas
On Thu, 16 Dec 2021 12:54:27 GMT, Jeanette Winzenburg wrote: >> Extracted static test utility methods from EditAndScrollTest into new >> VirtualizedControlTestUtils, added rudimentary tests for the methods. > > Jeanette Winzenburg has updated the pull request incrementally with one >

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-16 Thread Ajit Ghaisas
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]

2021-12-16 Thread Jeanette Winzenburg
> Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision: fixed c error in doc

Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]

2021-12-16 Thread Jeanette Winzenburg
On Thu, 16 Dec 2021 11:00:39 GMT, Ajit Ghaisas wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed c error in doc > >

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-16 Thread Johan Vos
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-16 Thread Kevin Rushforth
On Thu, 16 Dec 2021 01:33:31 GMT, Michael Strauß wrote: > Here are my results when building with `-PCONF=Release` on macOS 11.6.1: My guess is that the differences are due to either your macOS version or the Xcode you used to build, and that your "current" numbers would also be different from

Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)

2021-12-16 Thread Ajit Ghaisas
On Thu, 9 Dec 2021 12:43:54 GMT, Jeanette Winzenburg wrote: > Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. This looks good except for a typo which is not introduced by you!