Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v3]

2022-01-28 Thread Marius Hanl
On Fri, 28 Jan 2022 12:40:15 GMT, Jeanette Winzenburg wrote: >> I can align it. And yeah makes sense to add a test for the >> TreeTableView/TreeTableCell. > > just curious: why didn't you move the tests into TableColumnHeaderTest? I had no particular reason, I think the test fits both

Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v3]

2022-01-28 Thread Jeanette Winzenburg
On Thu, 27 Jan 2022 10:21:18 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java >> line 371: >> >>> 369: @Test >>> 370: public void testRowIsNotNullWhenAutoSizing() { >>> 371: TableColumn tableColumn = new

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v4]

2022-01-28 Thread Kevin Rushforth
On Thu, 27 Jan 2022 19:57:13 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v4]

2022-01-28 Thread Jeanette Winzenburg
On Thu, 27 Jan 2022 20:48:40 GMT, Marius Hanl wrote: >> When a divider is moved via drag or code it will call **requestLayout()** >> for the **SplitPane**. >> While this is fine, it is also called when the >> **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider. >> >> This