Re: RFR: 8284654: Modal behavior returns to wrong stage

2022-04-22 Thread Kevin Rushforth
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao wrote: > When there's an APPLICATION_MODAL window, all other windows are disabled and > re-enabled when the APPLICATION_MODAL window closes. This causes > `requestToFront()` to be called on every window, and it does not guarantee >

RFR: 8284654: Modal behavior returns to wrong stage

2022-04-22 Thread Thiago Milczarek Sayao
When there's an APPLICATION_MODAL window, all other windows are disabled and re-enabled when the APPLICATION_MODAL window closes. This causes `requestToFront()` to be called on every window, and it does not guarantee order. The fix also works for:

Integrated: 8193442: Removing TreeItem from a TreeTableView sometime changes selectedItem

2022-04-22 Thread Jose Pereda
On Mon, 14 Mar 2022 14:49:41 GMT, Jose Pereda wrote: > This PR fixes > JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also > [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and verifies > that the tests mentioned in >

Re: RFR: 8193442: Removing TreeItem from a TreeTableView sometime changes selectedItem [v3]

2022-04-22 Thread Kevin Rushforth
On Thu, 21 Apr 2022 08:37:11 GMT, Jose Pereda wrote: >> This PR fixes >> JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also >> [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and >> verifies that the tests mentioned in >>

Integrated: 8278430 : Several tests use terminally deprecated System.runFinalization method

2022-04-22 Thread Hima Bindu Meda
On Thu, 21 Apr 2022 15:03:04 GMT, Hima Bindu Meda wrote: > This PR is to remove calls to deprecated method System.runFinalization. > Here is the list of module wise test cases affected by the removal: > > **web**: > test.javafx.scene.web.LeakTest > > **systemTests**: >

Re: RFR: 8193442: Removing TreeItem from a TreeTableView sometime changes selectedItem [v3]

2022-04-22 Thread Ajit Ghaisas
On Thu, 21 Apr 2022 08:37:11 GMT, Jose Pereda wrote: >> This PR fixes >> JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also >> [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and >> verifies that the tests mentioned in >>

Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests [v2]

2022-04-22 Thread Ambarish Rapte
On Fri, 22 Apr 2022 07:30:25 GMT, Ajit Ghaisas wrote: >> This PR is to cleanup a few `javafx.controls` unit tests that were ignored. >> >> Here is the list of targeted unit test classes- >> - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, >> `PaginationTest` >> - Ignored

Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests [v2]

2022-04-22 Thread Ajit Ghaisas
On Fri, 22 Apr 2022 06:27:49 GMT, Ambarish Rapte wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address review comments > > modules/javafx.controls/src/test/java/test/javafx/scene/control/CellTest.java > line

Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests [v2]

2022-04-22 Thread Ajit Ghaisas
> This PR is to cleanup a few `javafx.controls` unit tests that were ignored. > > Here is the list of targeted unit test classes- > - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, > `PaginationTest` > - Ignored tests removed - `RadioMenuItemTest`, `PopupControlTest` > >

Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests

2022-04-22 Thread Ambarish Rapte
On Thu, 21 Apr 2022 11:23:35 GMT, Ajit Ghaisas wrote: > This PR is to cleanup a few `javafx.controls` unit tests that were ignored. > > Here is the list of targeted unit test classes- > - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, > `PaginationTest` > - Ignored tests