RFR: 8277756: DatePicker listener might not be added when using second constructor

2022-05-24 Thread Marius Hanl
The `valueProperty()` and `chronologyProperty()` listener are now added in the second constructor of `DatePicker` (`public DatePicker(LocalDate localDate)`) instead of the first one (`public DatePicker()`). Therefore, both listener are now added no matter which constructor is used.

Re: RFR: 8218826: TableRowSkinBase: horizontal layout broken if row has padding

2022-05-24 Thread Marius Hanl
On Tue, 24 May 2022 21:25:23 GMT, Marius Hanl wrote: > This PR fixes a problem, where the layout is broken when a `(Tree)TableRow` > has padding. > As also mentioned in the ticket, the `layoutChildren` method in > `TableRowSkinBase` is implemented wrong. > > The `layoutChildren` method is

RFR: 8218826: TableRowSkinBase: horizontal layout broken if row has padding

2022-05-24 Thread Marius Hanl
This PR fixes a problem, where the layout is broken when a `(Tree)TableRow` has padding. As also mentioned in the ticket, the `layoutChildren` method in `TableRowSkinBase` is implemented wrong. The `layoutChildren` method is responsible for layouting all the `(Tree)TableCells`. When the row

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-05-24 Thread Kevin Rushforth
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

[jfx17u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:34:25 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 1835d1f5 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/1835d1f59104136d6cb34090bd69091433ddac00 Stats: 5484

[jfx17u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:33:57 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 7b1637f8 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/7b1637f8f617639ddc0c93e15589824c6a0d71b1 Stats: 21664

[jfx11u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:31:58 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: f89a5139 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/f89a513980c2c2637c4f3d2b80f0708fd6f9e252 Stats: 5484

[jfx11u] Integrated: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx11u/pull/102/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=102=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283869

[jfx11u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx11u`. - Commit messages: - 8286256: Update libxml2 to 2.9.14 Changes: https://git.openjdk.java.net/jfx11u/pull/101/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=101=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286256 Stats: 21664

[jfx11u] Integrated: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
On Tue, 24 May 2022 17:31:27 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. This pull request has now been integrated. Changeset: 8504dad2 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/8504dad26ac0f0dcbf7cb62ac58642dc8a91f02e Stats: 21664

[jfx17u] RFR: 8283869: Update attribution in webkit.md file

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx17u/pull/62/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=62=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283869 Stats:

[jfx17u] RFR: 8286256: Update libxml2 to 2.9.14

2022-05-24 Thread Kevin Rushforth
Clean backport to `jfx17u`. - Commit messages: - 8286256: Update libxml2 to 2.9.14 Changes: https://git.openjdk.java.net/jfx17u/pull/61/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=61=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286256 Stats: 21664 lines

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-24 Thread Jay Bhaskar
On Tue, 24 May 2022 14:54:19 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JGObject in plave of raw jni object > >

Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v4]

2022-05-24 Thread Kevin Rushforth
On Sun, 22 May 2022 14:06:41 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >>

Re: RFR: [WIP] 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v6]

2022-05-24 Thread Florian Kirmaier
On Mon, 23 May 2022 20:44:47 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when the size is changed >> in

Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView

2022-05-24 Thread Jose Pereda
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote: > This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail

Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView [v2]

2022-05-24 Thread Jose Pereda
> This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail without this PR (first selected > item gets