Re: How to set WM_CLASS for GNOME?

2022-06-09 Thread Abhinay Agarwal
Hi Alex, Do you have the following entry in the .desktop file of your application[1]: StartupWMClass=com.foo.bar.FooApplication -Abhinay [1] https://github.com/gluonhq/scenebuilder/pull/407 From: openjfx-dev on behalf of Alex Orlov Sent: Thursday, May 26,

[jfx18] Integrated: 8285475: Create release notes for 18.0.1

2022-04-26 Thread Abhinay Agarwal
On Mon, 25 Apr 2022 06:50:07 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 18.0.1 to the repository This pull request has now been integrated. Changeset: f0099c25 Author: Abhinay Agarwal Committer: Nir Lisker URL: https://git.openjdk.java.net/jfx/com

[jfx18] RFR: 8285475: Create release notes for 18.0.1

2022-04-26 Thread Abhinay Agarwal
Add release notes for JavaFX 18.0.1 to the repository - Commit messages: - Add list of security fixes - 8285475: Create release notes for 18.0.1 Changes: https://git.openjdk.java.net/jfx/pull/785/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=785=00 Issue:

[jfx18] Integrated: 8282766: Create release notes for JavaFX 18

2022-03-15 Thread Abhinay Agarwal
On Sat, 12 Mar 2022 10:18:07 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 18 to the repository This pull request has now been integrated. Changeset: df43d2bd Author: Abhinay Agarwal Committer: Johan Vos URL: https://git.openjdk.java.net/jfx/com

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Abhinay Agarwal
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > broug

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Abhinay Agarwal
On Mon, 14 Mar 2022 17:08:32 GMT, Kevin Rushforth wrote: >> Marked as reviewed by kcr (Lead). > >> @kevinrushforth Before I integrate the PR, can you have a look at [my >> comment on the >>

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Abhinay Agarwal
On Mon, 14 Mar 2022 13:31:34 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - s/Enhancement/Enhancements >> - Create release

Integrated: 8282093: LineChart path incorrect when outside lower bound

2022-03-14 Thread Abhinay Agarwal
On Mon, 28 Feb 2022 18:25:09 GMT, Abhinay Agarwal wrote: > This regression was caused in PR #667 in which I didn't take into account the > lower bounds. I have added more tests and one manual test along with the fix. > The manual test can be used to identify any future issues w

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-13 Thread Abhinay Agarwal
> Add release notes for JavaFX 18 to the repository Abhinay Agarwal has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits si

RFR: 8282766: Create release notes for JavaFX 18

2022-03-12 Thread Abhinay Agarwal
Add release notes for JavaFX 18 to the repository - Commit messages: - Create release notes for JavaFX 18 Changes: https://git.openjdk.java.net/jfx/pull/752/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=752=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282766

Re: RFR: 8282093: LineChart path incorrect when outside lower bound [v2]

2022-02-28 Thread Abhinay Agarwal
> This regression was caused in PR #667 in which I didn't take into account the > lower bounds. I have added more tests and one manual test along with the fix. > The manual test can be used to identify any future issues with paths outside > lower and upper bounds easily. Abhinay

RFR: 8282093: LineChart path incorrect when outside lower bound

2022-02-28 Thread Abhinay Agarwal
This regression was caused in PR #667 in which I didn't take into account the lower bounds. I have added more tests and one manual test along with the fix. The manual test can be used to identify any future issues with paths outside lower and upper bounds easily. - Commit

[jfx17u] Integrated: 8280172: Create release notes for JavaFX 17.0.2

2022-01-19 Thread Abhinay Agarwal
On Wed, 19 Jan 2022 10:58:54 GMT, Abhinay Agarwal wrote: > Release Notes for 17.0.2 This pull request has now been integrated. Changeset: 3aa459eb Author: Abhinay Agarwal Committer: Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/com

Re: [jfx17u] RFR: 8280172: Create release notes for JavaFX 17.0.2 [v4]

2022-01-19 Thread Abhinay Agarwal
> Release Notes for 17.0.2 Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Remove build and test changes - Changes: - all: https://git.openjdk.java.net/jfx17u/pull/28/files - new: https://git.openjdk.java.

Re: [jfx17u] RFR: 8280172: Create release notes for JavaFX 17.0.2 [v3]

2022-01-19 Thread Abhinay Agarwal
> Release Notes for 17.0.2 Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Add security fix - Changes: - all: https://git.openjdk.java.net/jfx17u/pull/28/files - new: https://git.openjdk.java.net/jfx17u/pull

Re: [jfx17u] RFR: 8280172: Create release notes for JavaFX 17.0.2 [v2]

2022-01-19 Thread Abhinay Agarwal
On Wed, 19 Jan 2022 12:18:40 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix formatting > > doc-files/release-notes-17.0.2.md line 17:

Re: [jfx17u] RFR: 8280172: Create release notes for JavaFX 17.0.2 [v2]

2022-01-19 Thread Abhinay Agarwal
> Release Notes for 17.0.2 Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Fix formatting - Changes: - all: https://git.openjdk.java.net/jfx17u/pull/28/files - new: https://git.openjdk.java.net/jfx17u/pull

Re: [jfx17u] RFR: 8280172: Create release notes for JavaFX 17.0.2

2022-01-19 Thread Abhinay Agarwal
On Wed, 19 Jan 2022 10:58:54 GMT, Abhinay Agarwal wrote: > Release Notes for 17.0.2 doc-files/release-notes-17.0.2.md line 18: > 16: | [JDK-8272638](https://bugs.openjdk.java.net/browse/JDK-8272638) | > Update copyright header for files modified in 2021 | other| >

[jfx17u] RFR: 8280172: Create release notes for JavaFX 17.0.2

2022-01-19 Thread Abhinay Agarwal
Release Notes for 17.0.2 - Commit messages: - 8280172: Create release notes for JavaFX 17.0.2 Changes: https://git.openjdk.java.net/jfx17u/pull/28/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=28=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280172 Stats:

Integrated: 8197991: Selecting many items in a TableView is very slow

2022-01-10 Thread Abhinay Agarwal
On Wed, 17 Nov 2021 05:34:46 GMT, Abhinay Agarwal wrote: > This work improves the performance of `MultipleSelectionModel` over large > data sets by caching some values and avoiding unnecessary calls to > `SelectedIndicesList#size`. It further improves the performance by reducing >

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v6]

2022-01-07 Thread Abhinay Agarwal
f an element in the > BitSet. > > The work is based on [an abandoned > patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs > > There are currently 2 manual tests for this fix. Abhinay Agarwal has updated the pull request incrementally with two additional c

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v5]

2022-01-06 Thread Abhinay Agarwal
On Thu, 6 Jan 2022 21:01:11 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove commented out method. Document constructors. >> - Add tests > > m

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2022-01-06 Thread Abhinay Agarwal
On Wed, 22 Dec 2021 13:32:06 GMT, Kevin Rushforth wrote: >> A cache that's manually invalidated and then validated when needed is a form >> of lazy evaluation. The main point, regardless of how you name it, is to >> ensure that every call that modifies the underlying BitSet invalidates the >>

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v5]

2022-01-06 Thread Abhinay Agarwal
f an element in the > BitSet. > > The work is based on [an abandoned > patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs > > There are currently 2 manual tests for this fix. Abhinay Agarwal has updated the pull request incrementally with two additional c

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2021-12-21 Thread Abhinay Agarwal
On Fri, 17 Dec 2021 17:46:54 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update ROW_COUNT to 700_000 > > modules/javafx.controls/src/

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v4]

2021-12-21 Thread Abhinay Agarwal
f an element in the > BitSet. > > The work is based on [an abandoned > patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs > > There are currently 2 manual tests for this fix. Abhinay Agarwal has updated the pull request incrementally with two additional c

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2021-12-21 Thread Abhinay Agarwal
On Fri, 17 Dec 2021 19:18:23 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update ROW_COUNT to 700_000 > > modules/javafx.controls/src/

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-12-15 Thread Abhinay Agarwal
On Tue, 23 Nov 2021 17:40:29 GMT, Kevin Rushforth wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2021-11-26 Thread Abhinay Agarwal
On Fri, 26 Nov 2021 13:10:08 GMT, yosbits wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update ROW_COUNT to 700_000 > > tests/manual/controls/SelectTableViewTest.java line 1

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2021-11-26 Thread Abhinay Agarwal
f an element in the > BitSet. > > The work is based on [an abandoned > patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs > > There are currently 2 manual tests for this fix. Abhinay Agarwal has updated the pull request incrementally with one additional

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v2]

2021-11-26 Thread Abhinay Agarwal
On Fri, 26 Nov 2021 12:54:59 GMT, yosbits wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove duplicate entry for test data > > tests/manual/controls/SelectListViewTest.java li

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v2]

2021-11-26 Thread Abhinay Agarwal
f an element in the > BitSet. > > The work is based on [an abandoned > patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs > > There are currently 2 manual tests for this fix. Abhinay Agarwal has updated the pull request incrementally with one additional

Integrated: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound

2021-11-25 Thread Abhinay Agarwal
On Fri, 12 Nov 2021 09:44:47 GMT, Abhinay Agarwal wrote: > PathElements were skipped in AreaChart if the data point were outside axis > bounds and had duplicate value for either x or y. This is now fixed with this > PR. This pull request has now been integrated. Changeset: 0dbdec

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-22 Thread Abhinay Agarwal
On Thu, 18 Nov 2021 08:53:07 GMT, Marius Hanl wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the number

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-22 Thread Abhinay Agarwal
On Thu, 18 Nov 2021 00:54:30 GMT, Nir Lisker wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the number

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-22 Thread Abhinay Agarwal
On Thu, 18 Nov 2021 09:06:08 GMT, Tom Schindl wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ReadOnlyUnbackedObservableList.java >> line 119: >> >>> 117: Object obj = get(i); >>> 118: if (o.equals(obj)) return i; >>> 119: } >> >>

Re: RFR: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound [v3]

2021-11-22 Thread Abhinay Agarwal
> PathElements were skipped in AreaChart if the data point were outside axis > bounds and had duplicate value for either x or y. This is now fixed with this > PR. Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Up

Re: RFR: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound [v2]

2021-11-22 Thread Abhinay Agarwal
On Wed, 17 Nov 2021 10:07:37 GMT, Ajit Ghaisas wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix condition and add more tests > > modules/javafx.controls/src/tes

Re: RFR: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound [v2]

2021-11-22 Thread Abhinay Agarwal
> PathElements were skipped in AreaChart if the data point were outside axis > bounds and had duplicate value for either x or y. This is now fixed with this > PR. Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Fix

RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-17 Thread Abhinay Agarwal
This work improves the performance of `MultipleSelectionModel` over large data sets by caching some values and avoiding unnecessary calls to `SelectedIndicesList#size`. It further improves the performance by reducing the number of iterations required to find the index of an element in the

RFR: 8276490: Incorrect path for duplicate x and y values, when path falls outside axis bound

2021-11-12 Thread Abhinay Agarwal
PathElements were skipped in AreaChart if the data point were outside axis bounds and had duplicate value for either x or y. This is now fixed with this PR. - Commit messages: - Remove trailing whitespace - Remove unwanted import - Update tests - 8276490: Incorrect path is

[jfx17u] Integrated: 8275361: Create release notes for JavaFX 17.0.1

2021-10-19 Thread Abhinay Agarwal
On Mon, 18 Oct 2021 12:59:17 GMT, Abhinay Agarwal wrote: > Release Notes for 17.0.1 This pull request has now been integrated. Changeset: 23545b4f Author: Abhinay Agarwal Committer: Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/23545b4fb3d963a052ad81452e06ac71a718a

[jfx17u] RFR: 8275361: Create release notes for JavaFX 17.0.1

2021-10-18 Thread Abhinay Agarwal
Release Notes for 17.0.1 - Commit messages: - 8275361: Create release notes for JavaFX 17.0.1 Changes: https://git.openjdk.java.net/jfx17u/pull/14/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=14=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275361 Stats:

[jfx17] Withdrawn: 8275361: Create release notes for JavaFX 17.0.1

2021-10-18 Thread Abhinay Agarwal
On Mon, 18 Oct 2021 03:42:37 GMT, Abhinay Agarwal wrote: > Release notes for 17.0.1 This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jfx/pull/644

[jfx17] RFR: 8275361: Create release notes for JavaFX 17.0.1

2021-10-17 Thread Abhinay Agarwal
Release notes for 17.0.1 - Commit messages: - Update content to match 15.0.1 release notes - 8275361: Create release notes for JavaFX 17.0.1 Changes: https://git.openjdk.java.net/jfx/pull/644/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=644=00 Issue:

Re: Enhancements for JavaFX 18

2021-10-01 Thread Abhinay Agarwal
Hi, I recently worked on removing a few left-over Traversal engine usage in ControlsFX [1]. It can be tricky, sometimes impossible, to get the traversal part right in a custom control which can be done using 2 lines if Traversal API was present [2]. This made me thinking if there is a scope

Integrated: 8172095: Let Node.managed become CSS-styleable

2021-09-18 Thread Abhinay Agarwal
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal wrote: > 8172095: Let Node.managed become CSS-styleable This pull request has now been integrated. Changeset: d356340b Author: Abhinay Agarwal Committer: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/com

Integrated: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-15 Thread Abhinay Agarwal
On Tue, 14 Sep 2021 20:59:47 GMT, Abhinay Agarwal wrote: > Re-introduce `Automatic-Module-Name` for empty jars until a better > alternative to empty jars has been finalized. This pull request has now been integrated. Changeset: 7329279e Author:Abhinay Agarwal Committer: Johan Vo

RFR: 8273754: Re-introduce Automatic-Module-Name in empty jars

2021-09-14 Thread Abhinay Agarwal
Re-introduce `Automatic-Module-Name` for empty jars until a better alternative to empty jars has been finalized. - Commit messages: - 8273754: Re-introduce Automatic-Module-Name in empty jars Changes: https://git.openjdk.java.net/jfx/pull/623/files Webrev:

Re: JavaFX 17 Maven Artifacts

2021-09-10 Thread Abhinay Agarwal
Hi Clemens, If you have any thoughts/suggestions, please let us know. -Abhinay From: clemens.lantha...@itarchitects.at Sent: Friday, September 10, 2021 6:46 PM To: Abhinay Agarwal Cc: openjfx-dev@openjdk.java.net Subject: Re: JavaFX 17 Maven Artifacts Thanks

JavaFX 17 Maven Artifacts

2021-09-10 Thread Abhinay Agarwal
JavaFX 17 Maven artifacts currently fail to compile modular JavaFX application. The non-modular application still works. To explain what's going on, let have a look at JavaFX and its Maven distribution since version 11: 1. JavaFX is distributed in non-platform (empty) and platform specific

Java 17 Maven Artifacts

2021-09-10 Thread Abhinay Agarwal
JavaFX 17 Maven artifacts currently fail to compile modular JavaFX application. The non-modular application still work. To explain what's going on, let have a look at JavaFX and its Maven distribution since version 11: 1. JavaFX is distributed in non-platform (empty) and platform specific

Re: [jfx17] RFR: 8273343: Create release notes for JavaFX 17 [v2]

2021-09-07 Thread Abhinay Agarwal
> Add release notes for JavaFX 17 to the repository Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Remove list items as per review - Changes: - all: https://git.openjdk.java.net/jfx/pull/619/files - new: ht

[jfx17] Integrated: 8273343: Create release notes for JavaFX 17

2021-09-07 Thread Abhinay Agarwal
On Tue, 7 Sep 2021 09:11:41 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 17 to the repository This pull request has now been integrated. Changeset: 24d0600a Author: Abhinay Agarwal Committer: Johan Vos URL: https://git.openjdk.java.net/jfx/com

[jfx17] RFR: 8273343: Create release notes for JavaFX 17

2021-09-07 Thread Abhinay Agarwal
Add release notes for JavaFX 17 to the repository - Commit messages: - 8273343: Create release notes for JavaFX 17 Changes: https://git.openjdk.java.net/jfx/pull/619/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=619=00 Issue:

Re: RFR: 8172095: Let Node.managed become CSS-styleable [v2]

2021-09-04 Thread Abhinay Agarwal
> 8172095: Let Node.managed become CSS-styleable Abhinay Agarwal has updated the pull request incrementally with two additional commits since the last revision: - Add default value tests for setting / getting the managed property - Replace with HTML equivalent code - Chan

Re: RFR: 8172095: Let Node.managed become CSS-styleable

2021-08-18 Thread Abhinay Agarwal
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal wrote: > 8172095: Let Node.managed become CSS-styleable I started a [discussion on the mailing list](https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-August/031520.html). Is there anything else pending to move this PR forw

Re: [External] : Re: apps compilation fails on ubuntu 20.04

2021-08-13 Thread Abhinay Agarwal
s include "**/*swt*.jar" includeEmptyDirs = false rename ".*swt.*jar", "swt-debug\\.jar" // duplicatesStrategy = DuplicatesStrategy.WARN } ________ From: Kevin Rushforth Sent: Friday, August 13, 2021 2:24 AM To: Abhinay Agarwal

Re: apps compilation fails on ubuntu 20.04

2021-08-12 Thread Abhinay Agarwal
On 8/12/2021 12:33 PM, Abhinay Agarwal wrote: > I am on Ubuntu 20.04. Using ANT 1.10.8, "gradlew apps" works for me. > > However, "gradlew sdk" fails for me since we upgraded to Gradle 7.0.1. I > always switch back to Gradle 6.9 to build a local sdk. > __

Managed Property - CSS Styleable

2021-08-12 Thread Abhinay Agarwal
Every now and then, I miss having the capability to (un)manage nodes in its Parent via CSS. There have been similar requests[1] in the past. A combination of visibility and -fx-managed would allow developers/designers to completely hide a node via CSS, without altering its height and width. I

Re: apps compilation fails on ubuntu 20.04

2021-08-12 Thread Abhinay Agarwal
I am on Ubuntu 20.04. Using ANT 1.10.8, "gradlew apps" works for me. However, "gradlew sdk" fails for me since we upgraded to Gradle 7.0.1. I always switch back to Gradle 6.9 to build a local sdk. From: openjfx-dev on behalf of Thiago Milczarek Sayão Sent:

Re: RFR: 8172095: Let Node.managed become CSS-styleable

2021-08-12 Thread Abhinay Agarwal
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal wrote: > 8172095: Let Node.managed become CSS-styleable CSR: https://bugs.openjdk.java.net/browse/JDK-8272386 - PR: https://git.openjdk.java.net/jfx/pull/602

Re: RFR: JDK-8172095: Let Node.managed become CSS-styleable

2021-08-12 Thread Abhinay Agarwal
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal wrote: > JDK-8172095: Let Node.managed become CSS-styleable Thanks for the feedback. I will create a CSR and start a thread on the mailing list. - PR: https://git.openjdk.java.net/jfx/pull/602

Re: RFR: JDK-8172095: Let Node.managed become CSS-styleable

2021-08-12 Thread Abhinay Agarwal
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal wrote: > JDK-8172095: Let Node.managed become CSS-styleable Past OpenJFX mailing list discussion: http://mail.openjdk.java.net/pipermail/openjfx-dev/2015-July/017597.html - PR: https://git.openjdk.java.net/jfx/pull/602

RFR: JDK-8172095: Let Node.managed become CSS-styleable

2021-08-12 Thread Abhinay Agarwal
JDK-8172095: Let Node.managed become CSS-styleable - Commit messages: - JDK-8172095: Let Node.managed become CSS-styleable Changes: https://git.openjdk.java.net/jfx/pull/602/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=602=00 Issue:

Integrated: 8264998: Empty Jars shouldn't have Automatic-Module-Name

2021-05-03 Thread Abhinay Agarwal
On Fri, 30 Apr 2021 08:42:14 GMT, Abhinay Agarwal wrote: > 8264998: Empty Jars shouldn't have Automatic-Module-Name This pull request has now been integrated. Changeset: 02b078a8 Author: Abhinay Agarwal Committer: Johan Vos URL: https://git.openjdk.java.net/jfx/com

RFR: JDK-8264998: Remove Automatic-Module-Name from empty jars

2021-04-30 Thread Abhinay Agarwal
JDK-8264998: Remove Automatic-Module-Name from empty jars - Commit messages: - JDK-8264998: Remove Automatic-Module-Name from empty jars Changes: https://git.openjdk.java.net/jfx/pull/484/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=484=00 Issue:

[jfx16] Integrated: 8262460: Create release notes for JavaFX 16

2021-03-04 Thread Abhinay Agarwal
On Tue, 2 Mar 2021 18:25:14 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 16 to the repository This pull request has now been integrated. Changeset: e0ce73a3 Author: Abhinay Agarwal Committer: Johan Vos URL: https://git.openjdk.java.net/jfx/commit/e0ce73a3 St

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v2]

2021-03-03 Thread Abhinay Agarwal
On Wed, 3 Mar 2021 13:21:06 GMT, Kevin Rushforth wrote: > https://bugs.openjdk.java.net/issues/?filter=40381 Hi @kevinrushforth , Thanks for this list. You may want to add `test_sprint` to the list of labels :) - PR: https://git.openjdk.java.net/jfx/pull/414

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v5]

2021-03-03 Thread Abhinay Agarwal
> Add release notes for JavaFX 16 to the repository Abhinay Agarwal has updated the pull request incrementally with two additional commits since the last revision: - 8262460: Fix markdown table layout - 8262460: Add release notes for JDK-8256362 and JDK-8196079. Remove test bugs and bu

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-03 Thread Abhinay Agarwal
On Wed, 3 Mar 2021 13:09:51 GMT, Nir Lisker wrote: >> Right, I was confused when I saw the tag 15.0.1+0 but it is indeed in 15. > > There might be other issues like that. Maybe the backport issue type should > be filtered. This has already been taken care of. I have removed all the issues

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v4]

2021-03-02 Thread Abhinay Agarwal
> Add release notes for JavaFX 16 to the repository Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: 8262460: Sort issues first by sub-component followed by bug id - Changes: - all: https://git.openjdk.java.net/

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Abhinay Agarwal
On Tue, 2 Mar 2021 19:00:07 GMT, Nir Lisker wrote: >> Abhinay Agarwal has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > doc-files/rel

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Abhinay Agarwal
> Add release notes for JavaFX 16 to the repository Abhinay Agarwal has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit si

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v2]

2021-03-02 Thread Abhinay Agarwal
> Add release notes for JavaFX 16 to the repository Abhinay Agarwal has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 27 additional commits si

RFR: 8262460: Create release notes for JavaFX 16

2021-03-02 Thread Abhinay Agarwal
Add release notes for JavaFX 16 to the repository - Commit messages: - 8262460: Create release notes for JavaFX 16 Changes: https://git.openjdk.java.net/jfx/pull/414/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=414=00 Issue:

Integrated: 8261460: Incorrect CSS applied to ContextMenu on DialogPane

2021-02-19 Thread Abhinay Agarwal
On Wed, 10 Feb 2021 08:52:55 GMT, Abhinay Agarwal wrote: > Both DialogPane and ContextMenu have a child node with a style-class > `graphic-container`. This leads to a corner case where an unwanted style is > applied to ContextMenu when it is shown on a DialogPane. This pull reques

RFR: 8261460: Incorrect CSS applied to ContextMenu on DialogPane

2021-02-12 Thread Abhinay Agarwal
Both DialogPane and ContextMenu have a child node with a style-class `graphic-container`. This leads to a corner case where an unwanted style is applied to ContextMenu when it is shown on a DialogPane. - Commit messages: - Remove executable flag from image and move it to correct

Move EventHandlerManager to public API

2020-10-19 Thread Abhinay Agarwal
Hi, Classes which extends Node have access to the protected method `setEventHandler`[1]. It makes it exceptional easy to register a user-defined onXXX event handler. However, for custom EventTarget which do not extend Node, it becomes cumbersome as JavaFX expects us to create a whole new

Integrated: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-07-30 Thread Abhinay Agarwal
On Thu, 14 May 2020 19:22:54 GMT, Abhinay Agarwal wrote: > In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v6]

2020-06-25 Thread Abhinay Agarwal
ready has focus but the keyboard > is not visible. Ideally, the keyboard > should be shown again when the user taps on the TextInputControl. > This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows > the keyboard if the TextInput control is > both editable

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v5]

2020-06-25 Thread Abhinay Agarwal
ready has focus but the keyboard > is not visible. Ideally, the keyboard > should be shown again when the user taps on the TextInputControl. > This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows > the keyboard if the TextInput control is > both editable

Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-06-12 Thread Abhinay Agarwal
On Fri, 29 May 2020 16:48:29 GMT, Johan Vos wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo: dispose should remove event handler > > worth discussing the case were a

Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Abhinay Agarwal
ready has focus but the keyboard > is not visible. Ideally, the keyboard > should be shown again when the user taps on the TextInputControl. > This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows > the keyboard if the TextInput control is > both editable

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
On Tue, 19 May 2020 09:23:38 GMT, Jeanette Winzenburg wrote: >> @kleopatra Done! > > wondering if there is any way to include android specific skins in unit > testing? For all (nearly, htmlEditor excluded > ;) others we have a test to guard against contract violations (and will soon > have

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
ready has focus but the keyboard > is not visible. Ideally, the keyboard > should be shown again when the user taps on the TextInputControl. > This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows > the keyboard if the TextInput control is > both editable

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
On Fri, 15 May 2020 10:58:14 GMT, Jeanette Winzenburg wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard.

Re: [Rev 01] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
ready has focus but the keyboard > is not visible. Ideally, the keyboard > should be shown again when the user taps on the TextInputControl. > This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows > the keyboard if the TextInput control is > both editable

RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-14 Thread Abhinay Agarwal
In Android, TextInputControls (TextField and TextArea) are responsible for showing and hiding software keyboard. Currently, a focus listener is attached to these controls and is used to toggle the visibility of keyboard. This condition fails in cases where the control already has focus but the

Re: [Integrated] RFR: 8242077: Add information about HTTP/2 and HttpClient usage in WebEngine

2020-04-28 Thread Abhinay Agarwal
On Sun, 19 Apr 2020 08:12:07 GMT, Abhinay Agarwal wrote: > Update WebEngine's Javadoc to add information on how it switches to > HttpClient instead of URLConnection in JavaFX 14 > when used with JDK 12 or later. > Identification of the correct client is important as both these

Re: Remove JavaFX JPMS enforcement

2020-04-24 Thread Abhinay Agarwal
Hi Ty Young, I am trying to identify which part of the documentation changed after JavaFX 13. The JVM arguments that you have specified are required since JavaFX 11. Alternatively, user doesn't need to pass these arguments if they are using javafx-maven-plugin to build and run the application.

Re: Is it possible to customise the theme of the Scene Builder itself?

2020-04-23 Thread Abhinay Agarwal
Hi, Scene Builder is open-sourced [1]. If you find something can be improved, please feel free to send a PR. All the style-sheets use to style Scene Builder can be found in the repository [2]. -- Abhinay [1] https://github.com/gluonhq/scenebuilder [2]

Re: Scene Builder Support for javafx 14

2020-04-23 Thread Abhinay Agarwal
Hi Apurwa, Any FXML created by Scene Builder 11 can be used by JavaFX 14. > I tried downloading the latest version of Scene Builder but its not > compatible with javafx. Can you pleases explain what incompatibility issues are you facing? -- Abhinay From:

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing

2020-04-22 Thread Abhinay Agarwal
On Sat, 11 Apr 2020 09:53:46 GMT, Ambarish Rapte wrote: > The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several >

RFR: 8242077: Add information about HTTP/2 and HttpClient usage in WebEngine

2020-04-19 Thread Abhinay Agarwal
Update WebEngine's Javadoc to add information on how it switches to HttpClient instead of URLConnection in JavaFX 14 when used with JDK 12 or later. Identification the correct client is important as both these clients may offer different ways to achieve a task. One such task can be bypassing

Re: ComboBox keypress discrepancy

2020-03-24 Thread Abhinay Agarwal
/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/FocusTraversalInputMap.java#L53 P.S. I sincerely hope everyone in this mailing list are healthy and safe! From: Abhinay Agarwal Sent: Sunday, March 8, 2020 1:51 PM To: Dirk Lemmermann Cc: openjfx-dev

Re: ComboBox keypress discrepancy

2020-03-08 Thread Abhinay Agarwal
Hi Dirk, Exactly. The TAB key press event not firing at all seems fishy. -- Abhinay From: Dirk Lemmermann Sent: Friday, March 6, 2020 2:55 PM To: Abhinay Agarwal Cc: openjfx-dev@openjdk.java.net Subject: Re: ComboBox keypress discrepancy Regarding expected

Re: ComboBox keypress discrepancy

2020-03-05 Thread Abhinay Agarwal
: Dirk Lemmermann Sent: Thursday, March 5, 2020 6:39 PM To: Abhinay Agarwal Cc: openjfx-dev@openjdk.java.net Subject: Re: ComboBox keypress discrepancy So what info do you need? What test do you want us to run? I ran it on MacOS X with Java 14ea and I DO NOT see the „TAB“ output. Dirk Am

ComboBox keypress discrepancy

2020-03-05 Thread Abhinay Agarwal
Hi, We have come across a behavioural change in ComboBox b/w JavaFX 8 and 9+. We are not sure if its a regression or a bug fix which is causing it. Therefore, I am reaching out to the community for insight. If you run the following example, open the popup window in ComboBox and press TAB:

Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side

2020-02-10 Thread Abhinay Agarwal
? -- Abhinay From: openjfx-dev on behalf of Abhinay Agarwal Sent: Saturday, February 8, 2020 1:15 PM To: Kevin Rushforth ; openjfx-dev@openjdk.java.net Subject: Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side Hi Kevin, Yes, this is actually a pre-review mail to

  1   2   >