Fully custom theme vs overriding Modena

2021-03-31 Thread Ed Kennard
Hi all, I’m about to embark on some work which will remove our dependency on the Modena theme. We currently import Modena then override it wherever necessary, but now I want to replace that with our own custom CSS built from the ground up. The new custom CSS will be simpler and flatter than

Re: TableView with many columns poor ui performance

2020-02-06 Thread Ed Kennard
Great, thanks Danny, I’ll check it out and let you know how it goes From: Danny Gonzalez Date: Thursday, 6 February 2020 at 17:27 To: Ed Kennard Cc: "openjfx-dev@openjdk.java.net" Subject: Re: TableView with many columns poor ui performance Hi Ed, I have submitted a pu

Re: TableView with many columns poor ui performance

2020-02-06 Thread Ed Kennard
Hi Danny, This is great news, I've previously written about perf issues with TableView, do you have a branch I could try out which is rebased off current jfx master? On 06/02/2020, 10:40, "openjfx-dev on behalf of Danny Gonzalez" wrote: Hi, We have been struggling with our

Re: Memory leak issues related to 2 PRs in OpenJFX

2020-02-05 Thread Ed Kennard
the JavaFX application thread? My guess is that this is unlikely to be the problem, since you say that it is very reproducible, but I thought I'd ask. -- Kevin On 2/4/2020 9:48 AM, Ed Kennard wrote: > Hi everyone, > > I’ve been migrating our code

Memory leak issues related to 2 PRs in OpenJFX

2020-02-04 Thread Ed Kennard
Hi everyone, I’ve been migrating our codebase to Java 11 LTS and OpenJFX 14. One of our GC-related unit tests is failing now, where one of our custom Tab controls is supposed to be GC’d. The test passes against Java 8. When our GC-related unit tests fail they output exactly what it is that’s

Re: Release roadmap for 2 already-merged TableView PRs

2020-01-28 Thread Ed Kennard
Michael, Kevin, Great, will try out right away! Thanks! Ed On 28/01/2020, 13:58, "openjfx-dev on behalf of Michael Paus" wrote: Am 28.01.20 um 12:49 schrieb Ed Kennard: > It looks like the first opportunity to benefit from both changes is to wait for the upcomin

Re: TableView slow vertical scrolling with 300+ columns

2020-01-28 Thread Ed Kennard
oment I am still very occupied with our system launch, but I intend to participate soon in the community and give back a little bit of what we received from using JavaFX for free in our applications up to now. Greetings Clemens Am 25.01.2020 um 02:39 schrieb

Release roadmap for 2 already-merged TableView PRs

2020-01-28 Thread Ed Kennard
Hi everyone, In Java 9 there were some issues introduced into the TableView code which significantly reduced the extensibility of the skinning. These issues were blocking ones for us, in terms of migrating from 8 to 11, since we rely heavily on what was originally exposed, a good example

Re: TableView slow vertical scrolling with 300+ columns

2020-01-27 Thread Ed Kennard
Ed From: Jonathan Giles Date: Sunday, 26 January 2020 at 22:48 To: Ed Kennard Cc: Nir Lisker , "openjfx-dev@openjdk.java.net" Subject: Re: TableView slow vertical scrolling with 300+ columns It's been a wee while since I built TableView, but from memory the

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Ed Kennard
comments suggesting it has its own performance issues, too. I will revisit it though, just to be sure. Beyond that, I haven’t seen any other 3rd party libraries along these lines From: Nir Lisker Date: Saturday, 25 January 2020 at 16:40 To: Ed Kennard Cc: Kevin Rushforth , "openjf

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Ed Kennard
Hi Martin, Big thank you for your message, and for sharing your code. I took a look and it could definitely be a great starting point for me. The content we need to display is very simple, every cell just needs to display text, occasionally with an expand/collapse button on the left. So I

Re: TableView slow vertical scrolling with 300+ columns

2020-01-25 Thread Ed Kennard
.openjdk.java.net/issues/?jql=component %3D javafx > > On Sat, Jan 25, 2020 at 3:39 AM Ed Kennard wrote: > >> Hi everyone, >> >> I’m new to the list, so by way of a short introduction, I’ve been working >> with JavaFX for the last 4 years de

TableView slow vertical scrolling with 300+ columns

2020-01-24 Thread Ed Kennard
Hi everyone, I’m new to the list, so by way of a short introduction, I’ve been working with JavaFX for the last 4 years developing a commodities trading risk management system from the ground up for a software company I co-founded in London. All our code is written in Scala, the functional