Re: RFR: 8279396: Define version in .jcheck/conf

2022-01-04 Thread Erik Joelsson
On Tue, 4 Jan 2022 13:09:33 GMT, Kevin Rushforth wrote: > This patch adds the version property to `.jcheck/conf`. By doing this we can > remove the corresponding configuration from the Skara bots, which in turn > reduces the need for timing and general complexity of starting a new JavaFX >

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-11-03 Thread Erik Joelsson
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Erik Joelsson
Looks ok to me. /Erik On 2017-05-09 18:08, Kevin Rushforth wrote: Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package