I, require additional command
> line arguments to work, so just clicking run on the unit test won't work. I
> tend to run those from the command line, but it should be possible to make
> them run from Eclipse somehow. Regular unit tests run for me.
>
> On Wed, Aug 18, 2021 a
line? Many
thanks to anyone who can provide some answers.
Jonathan Vusich
g` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains eight additional
commits since the last revision:
On Mon, 26 Apr 2021 21:06:41 GMT, Kevin Rushforth wrote:
>> Well, it's complicated. The algorithm that calculates the required space for
>> the tick labels does not take into account the tick label rotation. I did
>> not look into adding this at this time because that opens up a lot of other
g` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request incrementally with one additional
commit since the last revision:
Updated per review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/342/files
- new: https://git.openjdk.java.net/jfx
On Fri, 23 Apr 2021 23:28:49 GMT, Kevin Rushforth wrote:
>> Jonathan Vusich has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add tests for vertical axis as well
>> - Improve layout calculation
On Wed, 3 Feb 2021 17:08:17 GMT, Jeanette Winzenburg
wrote:
>> wondering about the system test - what stands in the way to add a simple
>> "normal" unit test?
>
>>
>>
>> wondering about the system test - what stands in the way to add a simple
>> "normal" unit test?
>
> looks like there
On Mon, 1 Feb 2021 21:37:44 GMT, Kevin Rushforth wrote:
>> @JonathanVusich Once a review is in progress, please don't force-push your
>> branch without a compelling reason, since that makes it harder to do
>> incremental reviews. In the future, we recommend `git merge master` rather
>> than
g` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request incrementally with two additional
commits since the last revision:
- Add tests for vertical axis as well
- Improve layout calculations for rotated text
-
Changes:
- all: https://git.openjdk.java.net/jf
g` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Remove unused import
- Unrotate labels if there is enough space for them
- Added copyright header
- Added fix and test
g` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request incrementally with one additional
commit since the last revision:
Remove unused import
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/342/files
- new: https://git.openjdk.java.net/jfx
g` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request incrementally with one additional
commit since the last revision:
Unrotate labels if there is enough space for them
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/342/files
- new: https://
On Tue, 24 Nov 2020 22:21:04 GMT, Kevin Rushforth wrote:
>> Can you merge in the latest `jfx/master`? That way the GitHub actions
>> build/test will be run (although it won't run the new headful test). You
>> also need a copyright header as noted below.
>
> While this does fix the specific
g` is off, so this seems to be an appropriate fix.
Jonathan Vusich has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three additional
commits since the last revision:
On Wed, 11 Nov 2020 16:08:20 GMT, Kevin Rushforth wrote:
>> Jonathan Vusich has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
As noted in the corresponding JBS issue, `Axis` does not properly compute its
preferred height when `autoRanging` is turned off. The simplest fix seems to be
changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees if
there is not enough room for the category labels to layout
16 matches
Mail list logo
