Re: [8u] Review Request: RT-35629 Provide support so IDE's can include packaging tools - approved

2014-02-10 Thread Mark Howe
Version 01 of webrev looks good, approved On Feb 6, 2014, at 12:27 PM, Mark Howe wrote: > The keys to a BundleParamInfo should not be part bundle properties, these > should be fixed strings that never change once we publish them. > > The rest looks good. I haven't gone thro

Re: [8u] Review Request: RT-35629 Provide support so IDE's can include packaging tools

2014-02-06 Thread Mark Howe
The keys to a BundleParamInfo should not be part bundle properties, these should be fixed strings that never change once we publish them. The rest looks good. I haven't gone through every line in detail but I have been working with it for the last few weeks and think the concepts and design is

Re: 8 Review request for RT-31888: Linux: Exception in PackagerLib when moving file from /tmp

2013-11-21 Thread Mark Howe
Will do Thanks Mark On Nov 21, 2013, at 8:25 AM, Kevin Rushforth wrote: > Mark, > > https://javafx-jira.kenai.com/browse/RT-31888 > > Can you review this, please? > > Thanks. > > -- Kevin >

Re: Review request for RT-34236 FXMLLoader throws " java.lang.InternalError: CallerSensitive annotation expected at frame 1 "

2013-11-18 Thread Mark Howe
This is a slightly dialed back version. Basically the same thing as the first webrev except left the API for setEmbeddedLauncher, because that is used by some app.s Kevin and David please review http://cr.openjdk.java.net/~kcr/RT-34236.1/ On Nov 14, 2013, at 7:08 PM, Mark Howe wrote

Review request for RT-34236 FXMLLoader throws " java.lang.InternalError: CallerSensitive annotation expected at frame 1 "

2013-11-14 Thread Mark Howe
Jira: https://javafx-jira.kenai.com/browse/RT-34236 Webrev: http://cr.openjdk.java.net/~kcr/RT-34236/ Thanks Mark

Re: JNLP Change?

2013-08-28 Thread Mark Howe
Hi Daniel, I have created an issue for this https://javafx-jira.kenai.com/browse/RT-32590, we should be providing packager support as jar or jnlp attributes are added. Thanks Mark On Aug 26, 2013, at 7:19 PM, Daniel Zwolenski wrote: > Shouldn't/couldn't his be done by the JFX packaging tool

Re: Tracking down an NPE

2013-06-10 Thread Mark Howe
On Jun 10, 2013, at 3:38 PM, Daniel Zwolenski wrote: > Cool, thanks - so the native packager requires that every one of the JARs > used in the app (even the third party ones not built as part of the app) > have a manifest in them? That's going to be very nasty. > That was fixed in August, for

Re: Preloaders

2013-06-06 Thread Mark Howe
On Jun 6, 2013, at 12:52 AM, Danno Ferrin wrote: > > > On Wed, Jun 5, 2013 at 9:47 PM, Daniel Zwolenski wrote: > To sum up my previous major suggestions for a better world: > > - web deploy code should be separate module from native, and jar separate > again. Each native module (win, Linux,

Re: Preloaders

2013-06-05 Thread Mark Howe
p waiting for > the revolution and rebuilt the maven plugin to be less crap than it was but > its the underlying packaging tools that need the rewrite if JFX is ever going > to have a decent deployment option. > > On 05/06/2013, at 3:58 AM, Mark Howe wrote: > >> It sho

Re: Preloaders

2013-06-04 Thread Mark Howe
It should be the one within the bundle otherwise deploying an app bundle won't work. If you find otherwise please create an issue. Cheers Mark On May 29, 2013, at 6:51 AM, Scott Palmer wrote: > I think native bundles should use the preloader contained within. I use > the Preloader to implem

Re: Patches for packager tweaks

2013-05-31 Thread Mark Howe
me re-think what I should be doing with >> my free time. Even a formal rejection would be better. >> >> On Thu, May 30, 2013 at 8:08 PM, Kevin Rushforth >> wrote: >> Right. I was answering the general question. >> >> For the specific question, I