Vote: YES
On 4/28/16 11:16 AM, Kevin Rushforth wrote:
I hereby nominate Guru Hb [1] to OpenJFX Committer.
Guru is a member of JavaFX team at Oracle working on WebKit, who has
contributed 10 changesets [5] to OpenJFX, at least 8 of which are
significant.
Votes are due by May 12, 2016.
Only
Kevin and Jonathan,
Please review these changes to Ensemble8. The View Source feature
parses the source for Strings that look like urls, and was getting
thrown on using String.format to build a url programmatically.
Thanks,
--morris
BUG -
David and Kevin,
Please review this comment change to Ensemble8. I could not find any of
the PlaygroundProperties for radio buttons in NodePropertiesApp in 8u or
9-dev.
Thanks,
--morris
BUG - https://bugs.openjdk.java.net/browse/JDK-8087648
WEBREV -
Vote: YES
On 3/31/16 5:04 PM, Kevin Rushforth wrote:
I hereby nominate Murali Billa [1] to OpenJFX Committer.
Murali is a member of JavaFX team at Oracle working on WebKit, who has
contributed 10 changesets [5] to OpenJFX, at least 8 of which are
significant.
Votes are due by April 14,
As the Quantum author I will echo Johan that looking at the
QuantumToolkit.pulse() and QuantumRenderer.submitRenderJob() are good
places to start. Ignore the PaintCollector (Pain Collector :-) ) and pay
attention to the View Painters.
This article has good background.
Kevin, David and David,
Please review this small patch for changing a Mac system menu item,
where that item is a top level menu in the [NSApp mainMenu] menu bar.
The fix is to look specifically in the main menu for these items, and to
use the appropriate mechanism to set the title of that
of this webrev and will buy lunch
for anyone that actually goes through it next time I'm in Santa Clara.
Use the follow to test out the changes:
ant -Dplatforms.JDK_1.8.home=`/usr/libexec/java_home`
ensemble-generate-samples-class run
Thanks!
--morris meyer
WEBREV - http
Vote: YES
--morris
On 12/21/15 2:45 PM, David Hill wrote:
I hereby nominate Johan Vos to OpenJFX Committer.
Johan Vos (jvos) has been active in the OpenJFX community, and
instrumental in the maturity of Monocle, the owner of the Android and
IOS ports and is an OpenJFX Author.
A list of
Vadim and Kevin,
Please review this fix for the GlassCursor.m assertion failure.
Thanks,
--morris
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8144780.01a
BUG - https://bugs.openjdk.java.net/browse/JDK-8144780
it. The
TPE model is more startup, work, then shutdown, and the QuantumToolkit
intermediates JavaFX application state with that model.
Best regards,
--morris meyer
On 11/22/15 6:24 AM, Johan Vos wrote:
I implemented this in the javafxports clone of the OpenJFX 8u-dev repo
Kevin, Jonathan and Leif,
Could you please review my changes for 8091485? The issues that I found
are enumerated in the bug description.
Thanks much,
--morris
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8091485.01/
BUG - https://bugs.openjdk.java.net/browse/JDK-8091485
Kevin and Vadim,
Could you please review my changes for the post-commit cleanup to
JDK-8144354?
Vadim regarding folding:
if (timeSlider.isValueChanging()) {
// multiply duration by percentage calculated by
slider position
if
Kevin and Jonathan,
Please review my changes to Modena that allow it to work with the
Jake-JavaFX build.
Thanks much,
--morris meyer
BUG - https://bugs.openjdk.java.net/browse/JDK-8134366
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8134366.03
Jonathan and Kevin,
Please review this simple fix to DragEvent.java. It uses the existing
template for the acceptingObject and has been tested on Mac and Windows.
Thanks much,
--morris
BUG - https://bugs.openjdk.java.net/browse/JDK-8088993
WEBREV -
(A as system);
barA.useSystemMenuBarProperty().bindBidirectional(aAsSystem.selectedProperty());
ToggleButton bAsSystem = new ToggleButton(B as system);
barB.useSystemMenuBarProperty().bindBidirectional(bAsSystem.selectedProperty());
Thanks for the review.
--morris meyer
JBS - https
Kevin and David,
Please review the following one-line fix to 8094649. This issue was
caused by a race condition between start of touch tracking and the
closing out the splash screen without removing the touch tracking. It
was messaging the invalid ObjC object for the GlassViewDelegate and
method it could be a
possible candidate for inclusion in 8u60.
Thanks much,
--morris meyer
JIRA - https://javafx-jira.kenai.com/browse/RT-46170
WEBREV - http://cr.openjdk.java.net/~morris/RT-46170.01/
David, Kevin et al,
Please review this simple fix for RT-37411. It is pretty low risk
vis-a-vis 8u60.
Thanks much.
--morris meyer
JIRA - https://javafx-jira.kenai.com/browse/RT-37411
WEBREV - http://cr.openjdk.java.net/~morris/RT-37411.01/
For those of us who weren't born yesterday,
Please review the following issue in Ensemble8. The SimpleDataFormat
was using minutes in hours instead of months for the formatted string.
Thanks,
--morris
WEBREV - http://cr.openjdk.java.net/~morris/RT-46093.01/
JIRA -
Hi Pedro,
You might want to try setting the flags quantum.debug, quantum.pulse
and quantum.verbose when launching your application.
Prior to that you might want to try to get a stack trace of the hung
application using jstack, Visual VM or doing a Ctrl-Break on Windows or
Control-\ on Mac.
Kevin and David,
Please review my changes to GlassCursor.m to fix the lack of proper Mac
NW, SW, SE and NE resize cursors.
As the look-up for these cursors was a little involved, I opted to use a
one-time cache so as not to induce any noticeable visual lag when
setting these cursors.
Jonathan and Leif,
Please review the css changes for Caspian and Modena for the color
picker custom color chooser. We need a bit more than 1em for
settings-unit in CustomColorDialog.java when running on Mac 10.10.
Tested on 10.10.4.
Thanks much.
--morris
JIRA -
Jonathan, Kevin and David,
Please review these layout changes to the Spinner Ensemble sample to
proportionally layout the different Spinners.
Thanks much.
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-40199
WEBREV - http://cr.openjdk.java.net/~morris/RT-40199.01/
David and Kevin,
Please review my fix for the recent regression caused by my fix for
RT-39813. Both changes crop up in the systemTests and are necessary to
adjust for the close sequence timing change introduced in RT-39813.
Tested using:
gradle -PFULL_TEST=true :systemTests:test
Thanks
Kevin, David and Chien,
Please review this patch, which fixes RT-38836 (a critical) and RT-23363
(a medium). It clips the frame to screen size in Glass-Mac in a similar
fashion to what happens in Glass-Windows.
Thanks much,
--morris
WEBREV -
, there is no way to
maximize the window on two monitors in multi-monitors configuration?
Does this issue affects an applets? Seems that on Windows the clipping
on the screen bounds is a default native behavior.
27.03.15 22:39, Morris Meyer wrote:
Kevin, David and Chien,
Please review this patch
Kevin, Chien and David,
Please review my fix for this Mac Stage focus close issue. The Mac OSX
internals were forcing a callback event onto a non-focused window, and
this preemptively asserts focus before allowing the event through.
--morris
WEBREV -
Kevin, David, Danno and Chien,
Please review these changes to add Mac system menu bar naming support to
JavaFX based on the JavaRuntimeSupport foundation that the JDK uses for
-Xdock:name via JRSAppkitAWT methods.
On the Mac the application name needs to be available prior to the
runLoop
Kevin, David and Jonathan,
Could you please review my accessibility additions to HelloCheckBox?
Thanks much,
--morris
WEBREV - http://cr.openjdk.java.net/~morris/RT-39108.01
JIRA - https://javafx-jira.kenai.com/browse/RT-39108
Folks,
Could I get a review of these changes? As Glass invokeLater is not
thread-safe, and since the JNI native method
MacApplication._submitForLaterInvocation() only adds the GlassRunnable
when the event thread is still running and Java is still around, I'm
dealing with this extraneous
Kevin, Jonathan and David,
Could you please review these changes to Ensemble8 to update the FX API
docs urls to point to their proper places?
Thanks much,
--morris
WEBREV - http://cr.openjdk.java.net/~morris/RT-40008.01/
JIRA - https://javafx-jira.kenai.com/browse/RT-40008
David and Kevin,
Could you review this change? The change set is per the description in
JIRA, and has been tested by Nicholas Myers.
Thanks much.
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-40032
WEBREV - http://cr.openjdk.java.net/~morris/RT-40032.01
Kevin and David,
Could you please take a look at this fix to RT-39869? I added some
checking to avoid the IOOBE from the native Glass system menus.
Thanks,
--morris
WEBREV - http://cr.openjdk.java.net/~morris/RT-39869.01
JIRA - https://javafx-jira.kenai.com/browse/RT-39869
Kevin, David and Chien,
Could you review my fix for this regression? I have tested this on Mac
OSX 10.10.3 (pre-release).
Thanks much.
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-39855
WEBREV - http://cr.openjdk.java.net/~morris/RT-39855
What JDK are you using? That looks like an older version of the String class.
Gradle 1.8 is recommended.
--mm
On Dec 28, 2014, at 7:35 PM, Nick Pratt nbpr...@gmail.com wrote:
Does anyone have any tips on getting Openjfx (latest source as of
2014-12-28 19:00 EST) to build on a Centos
Folks,
Could I get a quick review for this fix-up of the alignment in two
Ensemble apps?
Thanks much.
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-34958
WEBREV - http://cr.openjdk.java.net/~morris/RT-34958.01
Kevin and Chien,
Please review this simple fix for the 3DViewer SessionManager class to
take care of read-only file system errors when trying to save the
session file.
Thanks much,
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-34840
WEBREV -
David and Kevin,
Please review this very small change to prevent a spurious warning when
de-allocation occurs for a NSWindow instance after the Java VM has shutdown.
Thanks much,
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-39688
WEBREV -
Kevin and David,
Please review this patch for the issue added with the 10.10.2 software
patch that deals with part of the NSTouch interface changing.
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-39489
WEBREV - http://cr.openjdk.java.net/~morris/RT-39489.01/
David, Kevin and Chien,
Please review my fix for RT-34668 to remove the spurious extra runnable
that sometimes pops up after applications are quit on the Mac.
Thanks,
--morris
BUG - https://javafx-jira.kenai.com/browse/RT-34668
WEBREV - http://cr.openjdk.java.net/~morris/RT-34668.01
David and Kevin,
Could you please review the following change to remove the extraneous
Windows COM debug output from Glass drag-and-drop?
Thanks much,
--morris
JIRA - https://javafx-jira.kenai.com/browse/RT-38641
WEBREV - http://cr.openjdk.java.net/~morris/RT-38641.01/
Folks,
Could you please review the new Dialog app for Ensemble8?
Thanks much!
--mm
WEBREV - http://cr.openjdk.java.net/~morris/RT-39121.01
BUG - https://javafx-jira.kenai.com/browse/RT-39121
Folks,
Please review the new icon.
Thanks,
--morris
WEBREV - http://cr.openjdk.java.net/~morris/RT-39101.01
BUG - https://javafx-jira.kenai.com/browse/RT-39101
Folks,
I've uploaded the initial webrev for this issue for review.
Thanks much!
--morris meyer
JIRA - https://javafx-jira.kenai.com/browse/RT-23363
WEBREV - http://cr.openjdk.java.net/~morris/RT-23363.01
Folks,
I've uploaded the initial webrev for this issue for review.
Thanks much!
--morris meyer
JIRA - https://javafx-jira.kenai.com/browse/RT-37693
WEBREV - http://cr.openjdk.java.net/~morris/RT-37693.01
Here is my latest webrev based on Jonathan's comments in JIRA for RT-38058.
--morris
WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.02
On 10/6/14, 3:53 PM, Morris Meyer wrote:
Here is an open webrev:
WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.01
On 10/6/14, 2:50 PM
Jonathan,
I've pulled out the following patch from this JIRA issue and used
jvisualvm to verify that this indeed does solve our pagination leak
using the HelloPagination app.
Could you please give this a review? Thanks.
--morris
BUG - https://javafx-jira.kenai/browse/RT-38058
Here is an open webrev:
WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.01
On 10/6/14, 2:50 PM, Morris Meyer wrote:
Jonathan,
I've pulled out the following patch from this JIRA issue and used
jvisualvm to verify that this indeed does solve our pagination leak
using the HelloPagination
48 matches
Mail list logo