On Tue, 23 Mar 2021 19:17:20 GMT, Kevin Rushforth wrote:
>> Fix looks good. Tested WebView by reconnecting via remote desktop.
>
> @Schmidor did you have any further comments or feedback?
>
> Btw, I realized that you don't have a role in the openjfx project, so you
> can't formally review it.
On Thu, 18 Mar 2021 15:30:13 GMT, Kevin Rushforth wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>>
> contents are not rendered anymore.
> Reinitializing the whole pipeline fixes that.
Oliver Schmidtmer has updated the pull request incrementally with two
additional commits since the last revision:
- Ressource already freed from pool
- Recreate if adapterCount is zero
-
On Tue, 13 Oct 2020 16:22:36 GMT, Oliver Schmidtmer
wrote:
>>> The full recreation of the pipeline is only done when D3DERR_DEVICEREMOVED
>>> is occurring
>>
>> I see that now. That part is fine then.
>>
>> Another concern is that this
On Fri, 9 Oct 2020 23:17:27 GMT, Kevin Rushforth wrote:
>> The full recreation of the pipeline is only done when D3DERR_DEVICEREMOVED
>> is occurring. On other causes of why the
>> device is not ready, only the factory reference in the painter is cleared.
>
>> The full recreation of the
On Thu, 8 Oct 2020 16:19:52 GMT, Kevin Rushforth wrote:
>> When connecting via Remote Desktop to a Windows 10 machine ans starting a
>> JavaFX application, the D3D pipeline is used
>> successfully. After closing the the Remote Desktop session and reconnecting,
>> the D3D requests fail with an
When connecting via Remote Desktop to a Windows 10 machine ans starting a
JavaFX application, the D3D pipeline is used
successfully. After closing the the Remote Desktop session and reconnecting,
the D3D requests fail with an
D3DERR_DEVICEREMOVED HResult, and the application contents are not
On Wed, 3 Jun 2020 15:46:36 GMT, Oliver Schmidtmer
wrote:
> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and
> Math.round produce different results and
> EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error
> on the line width a
lready proposed by the submitter in JBS-8220484.
>
> OCA is signed and send.
Oliver Schmidtmer has updated the pull request incrementally with two
additional commits since the last revision:
- run test only on windows
- Typo
-
Changes:
- all: https://git.openjdk.java.net/jfx/p
On Mon, 6 Jul 2020 23:31:28 GMT, Kevin Rushforth wrote:
>> build.gradle line 3611:
>>
>>> 3610: testCompile project(":swt")
>>> 3611: testCompile name: SWT_FILE_NAME
>>> 3612: }
>>
>> We can't have a dependency on `swt` from any other project. SWT tests need
>> to be
lready proposed by the submitter in JBS-8220484.
>
> OCA is signed and send.
Oliver Schmidtmer has updated the pull request incrementally with one
additional commit since the last revision:
move swt test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/246
On Mon, 6 Jul 2020 18:00:08 GMT, Kevin Rushforth wrote:
>> Oliver Schmidtmer has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR.
>
&
On Mon, 6 Jul 2020 18:18:20 GMT, Kevin Rushforth wrote:
>> Oliver Schmidtmer has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR.
>
&
lready proposed by the submitter in JBS-8220484.
>
> OCA is signed and send.
Oliver Schmidtmer has refreshed the contents of this pull request, and previous
commits have been removed. The
incremental views will show differences compared to the previous content of the
PR. The pull request con
On Fri, 3 Jul 2020 00:01:10 GMT, Kevin Rushforth wrote:
>> Oliver Schmidtmer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change to Math.ceil and add test
>
> tests/system/src/test/java/test/javafx/e
lready proposed by the submitter in JBS-8220484.
>
> OCA is signed and send.
Oliver Schmidtmer has updated the pull request incrementally with one
additional commit since the last revision:
more solid test with shim and style independent color
-
Changes:
- all: https://git
On Wed, 17 Jun 2020 07:32:46 GMT, Prasanta Sadhukhan
wrote:
>> Oliver Schmidtmer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change to Math.ceil and add test
>
> In 2D, we normally use sun.java2d.pi
lready proposed by the submitter in JBS-8220484.
>
> OCA is signed and send.
Oliver Schmidtmer has updated the pull request incrementally with one
additional commit since the last revision:
Change to Math.ceil and add test
-
Changes:
- all: https://git.openjdk.java.net/jfx/p
On Fri, 12 Jun 2020 20:43:18 GMT, Kevin Rushforth wrote:
>> @Schmidor in general, we don't use the `/issue` command to identify other
>> issues that happen to be fixed by a commit.
>> Rather, if they are the same bug, or if one is caused by the other, we would
>> closed the other one as a
In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and
Math.round produce different results and
EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error
on the line width and therefore sheared
rendering.
The changes were already proposed by the
20 matches
Mail list logo
