RE: CFV: New OpenJFX Committer: Pankaj Bansal

2020-10-27 Thread Rajath Kamath
Vote: YES -Original Message- From: Kevin Rushforth Sent: Friday, October 23, 2020 8:08 PM To: openjfx-dev@openjdk.java.net Subject: CFV: New OpenJFX Committer: Pankaj Bansal I hereby nominate Pankaj Bansal [1] to OpenJFX Committer. Pankaj is a member of Java client team at Oracle, who

RE: CFV: New OpenJFX Committer: Nir Lisker

2019-06-30 Thread Rajath Kamath
Vote: YES Best Regards, Rajath -Original Message- From: Kevin Rushforth Sent: Wednesday, June 26, 2019 3:14 AM To: openjfx-dev@openjdk.java.net; Nir Lisker Subject: CFV: New OpenJFX Committer: Nir Lisker I hereby nominate Nir Lisker [1] to OpenJFX Committer. Nir is an OpenJFX

RE: CFV: New OpenJFX Committer: Prem Balakrishnan

2018-07-12 Thread Rajath Kamath
Vote: Yes -Original Message- From: Kevin Rushforth Sent: Wednesday, July 11, 2018 5:12 AM To: openjfx-dev@openjdk.java.net; Prem Balakrishnan Subject: CFV: New OpenJFX Committer: Prem Balakrishnan I hereby nominate Prem Balakrishnan [1] to OpenJFX Committer. Prem is a member of

[11] Review Request - JDK-8088769: Alphachannel for transparent colors is not shown in HtmlEditor

2018-03-09 Thread Rajath Kamath
Hi Kevin, Murali, Please review this fix for HTMLEditor. Details of the fix mentioned in JBS. JBS : https://bugs.openjdk.java.net/browse/JDK-8088769 WebRev : HYPERLINK "http://cr.openjdk.java.net/%7Erkamath/8088769/webrev.00/; http://cr.openjdk.java.net/~rkamath/8088769/webrev.00/ Thanks,

[11] Review Request - JDK-8197488: [testbug] java.lang.IllegalStateException getting logged on stdout/stderr while running javafx unit tests

2018-03-08 Thread Rajath Kamath
Hi Kevin, Ajit, Please review this fix in TreeTableViewTest and TableViewTest for exceptions getting logged although unit test run is successful. Details in JBS. JBS : https://bugs.openjdk.java.net/browse/JDK-8197488 WebRev : HYPERLINK

[11] Review Request - JDK-8193185: [Windows] System test failures in scene size tests with HiDPI

2018-03-01 Thread Rajath Kamath
Hi Kevin, Ambarish, Please review this fix for ensuring scene size tests pass with fractional scale factor set as well. JBS : https://bugs.openjdk.java.net/browse/JDK-8193185 WebRev : http://cr.openjdk.java.net/~rkamath/8193185/webrev.00/ Thanks, Rajath

[11] Review Request - JDK-8170026: Some tests in RegionBackgroundFillUITest fail with fractional window scale

2018-02-21 Thread Rajath Kamath
Hi Kevin, Murali, Please review this fix for skipping specific tests when run on systems with fractional scale factor set. JBS : https://bugs.openjdk.java.net/browse/JDK-8170026 WebRev : http://cr.openjdk.java.net/~rkamath/8170026/webrev.00/ Thanks, Rajath

[11] Review Request - JDK-8196802: 3D unit tests listed as pass although they are actually skipped

2018-02-15 Thread Rajath Kamath
Hi Kevin, Murali, Please review this fix for skipping tests those are not run(because of missing feature support), instead of incorrectly listing as pass. JBS : https://bugs.openjdk.java.net/browse/JDK-8196802 WebRev : http://cr.openjdk.java.net/~rkamath/8196802/webrev.01/ Thanks, Rajath

[11] Review Request - JDK-8196615: Skip 3D unit tests on system without 3D capability

2018-02-02 Thread Rajath Kamath
Hi Kevin,Murali, Please review this fix for skipping 3D tests on systems with missing hardware support. JBS : https://bugs.openjdk.java.net/browse/JDK-8196615 WebRev : http://cr.openjdk.java.net/~rkamath/8196615/webrev.00/ Thanks, Rajath

[11] Review Request - JDK-8089454: [HTMLEditor] selection removes CENTER alignment

2018-01-31 Thread Rajath Kamath
Hi, Request to please review this fix in HTMLEditor. Details in JBS. JBS : https://bugs.openjdk.java.net/browse/JDK-8089454 WebRev : HYPERLINK "http://cr.openjdk.java.net/%7Erkamath/8089454/webrev.00/; http://cr.openjdk.java.net/~rkamath/8089454/webrev.00/ Thanks, Rajath

[11] Review Request - JDK-8089375: When WebWorker file is unaccessible, script should fail silently or post meaningful exception

2018-01-22 Thread Rajath Kamath
Hi , Please review this fix in the WebNodeAutomated test case. JBS : https://bugs.openjdk.java.net/browse/JDK-8089375 WebRev : http://cr.openjdk.java.net/~rkamath/8089375/webrev.00/ Thanks, Rajath

[11] Review Request - JDK-8165459: HTMLEditor clipboard toolbar buttons are disabled unexpectedly

2018-01-16 Thread Rajath Kamath
Hi Guru\Murali, Please review a fix for HTMLEditor. Details of the fix in JBS: JBS : https://bugs.openjdk.java.net/browse/JDK-8165459 WebRev : http://cr.openjdk.java.net/~rkamath/8165459/webrev.00/ Thanks, Rajath

[11] Review Request - JDK-8088925: Non opaque background cause NumberFormatException

2017-12-26 Thread Rajath Kamath
Hi Guru\Arun, Please review a fix for HTMLEditor. Details of the same mentioned in JBS: JBS : https://bugs.openjdk.java.net/browse/JDK-8088925 WebRev : http://cr.openjdk.java.net/~rkamath/8088925/webrev.00/ Thanks, Rajath

[10] Review request - 8090011: 'tab' key makes control loose focus

2017-11-27 Thread Rajath Kamath
Hi all, Please review a fix for HTMLEditor. Details mentioned in JBS: JBS : https://bugs.openjdk.java.net/browse/JDK-8090011 WebRev : http://cr.openjdk.java.net/~rkamath/8090011/webrev.00/ Thanks, Rajath

[webkit][10] Review request - 8187928: Images copied from clipboard not written in source file format

2017-10-19 Thread Rajath Kamath
Hi all, Please review a bug fix: JBS : https://bugs.openjdk.java.net/browse/JDK-8187928 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8187928/webrev.00/ Thanks, Rajath

[webkit][10] Review request - 8187726: Copy and Paste of Image not resulting in expected behavior

2017-09-21 Thread Rajath Kamath
Hi all, Please review a patch for fixing Copy and Paste functionality in FX WebView. Details in JBS. JBS : https://bugs.openjdk.java.net/browse/JDK-8187726 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8187726/webrev.00/ Thanks, Rajath

[webkit][10] Review request - 8187671: Drag and Drop of text or html results in an image

2017-09-20 Thread Rajath Kamath
Hi all, Please review a bug fix done for `Drag and Drop use case in WebView` explained in the JBS JBS : https://bugs.openjdk.java.net/browse/JDK-8187671 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8187671/webrev.00/ Thanks, Rajath

[webkit][10] Review request - 8089124: HTML5: Number input allows non-numeric input

2017-09-07 Thread Rajath Kamath
Hi all, Please review the patch for enabling HTML5 form validation. With this enabled, WebKit would by default show validation specific error message dialogs using Shadow DOM + CSS styled web elements. This will serve as a placeholder until the FX platform implementation of

[webkit][10] Review request - 8185314: Remove unused third-party python scripts from WebKit sources

2017-08-22 Thread Rajath Kamath
Hi Guru\Arun, Please review this simple cleanup of unused third-party library download scripts. JBS : https://bugs.openjdk.java.net/browse/JDK-8185314 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8185314/webrev.00/ Thanks, Rajath