Re: [jfx11u] RFR: 8285152: Change JavaFX release version to 11.0.16 in jfx11u

2022-04-20 Thread Kevin Rushforth
On Wed, 20 Apr 2022 06:37:08 GMT, Johan Vos wrote: > Update security version for JavaFX 11 to 16. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx11u/pull/83

Re: [jfx17u] RFR: 8285153: Change JavaFX release version to 17.0.4 in jfx17u

2022-04-20 Thread Kevin Rushforth
On Wed, 20 Apr 2022 06:43:32 GMT, Johan Vos wrote: > Update security version for JavaFX 17 to 4. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx17u/pull/40

Re: [jfx18] RFR: 8285181: Change JavaFX release version to 18.0.2 in jfx18 branch

2022-04-20 Thread Kevin Rushforth
On Wed, 20 Apr 2022 07:00:46 GMT, Johan Vos wrote: > Increase security version to 2 for JavaFX 18.0.2 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/776

[jfx18, jfx17u, jfx11u] RFR: Request to backport April 2022 CPU changes

2022-04-19 Thread Kevin Rushforth
Hi Johan, I request approval to backport the changes from the just-released April 2022 CPU to jfx:jfx18 (for 18.0.1), jfx17u (for 17.0.3) and to jfx11u (for 11.0.15) . https://github.com/kevinrushforth/jfx17u/compare/4af7ee97f3...cpu-2204-sync https://github.com/kevinrushforth/jfx11u/compare/

RFR: Request to sync April 2022 changes into jfx master

2022-04-19 Thread Kevin Rushforth
Hi Johan, I request approval to sync changes from to the just-released April 2022 CPU release into the 'master' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/d1110f4795...cpu-2204-sync As a note, the patches initia

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v3]

2022-04-16 Thread Kevin Rushforth
On Fri, 15 Apr 2022 23:29:54 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not abl

Re: [jfx18] RFR: 8278980: Update WebKit to 613.1

2022-04-13 Thread Kevin Rushforth
On Wed, 13 Apr 2022 12:35:18 GMT, Johan Vos wrote: > Co-authored-by: Ajit Ghaisas > Co-authored-by: Jay Bhaskar > Co-authored-by: Kevin Rushforth > Reviewed-by: kcr, jvos, aghaisas Marked as reviewed by kcr (Lead). I can confirm that this is a clean patch, even though Skara do

Re: [jfx18] RFR: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1 [v2]

2022-04-13 Thread Kevin Rushforth
On Wed, 13 Apr 2022 11:56:09 GMT, Johan Vos wrote: >> Update JavaFX release version to 18.0.1 in jfx18 branch > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Update version in .jcheck/conf to 18.0.1 Marked as reviewed by kcr

Re: backport requests for 18.0.1

2022-04-13 Thread Kevin Rushforth
Looks good. -- Kevin On 4/13/2022 2:16 AM, Johan Vos wrote: Hi Kevin, I request approval to backport the following issues to the jfx18 branch, for JavaFX 18.0.1: JDK-8278980: Update WebKit to 613.1 JDK-8281459: WebKit 613.1 build broken on M1 JDK-8281711: Cherry-pick WebKit 613.1 stabilizatio

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v2]

2022-04-13 Thread Kevin Rushforth
On Wed, 13 Apr 2022 07:48:44 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not abl

Re: [jfx18] RFR: 8284812: Change JavaFX release version in jfx18 branch to 18.0.1

2022-04-13 Thread Kevin Rushforth
On Wed, 13 Apr 2022 08:59:45 GMT, Johan Vos wrote: > Update JavaFX release version to 18.0.1 in jfx18 branch Starting with JavaFX 18, the JBS version number in [.jcheck/conf](https://github.com/openjdk/jfx/blob/jfx18/.jcheck/conf#L27) also needs to be updated per [UPDATING-VERSION.md](https:/

Re: RFR: 8283218: Update GStreamer to 1.20.1

2022-04-12 Thread Kevin Rushforth
On Fri, 8 Apr 2022 06:49:59 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. > - No changes to our code, except in GstAudioSpectrum.cpp > g_atomic_pointer_compare_and_exchange() was changed to > g_atomic_pointer_set(). For some reason I was not able to g

Re: RFR: 8283402: Update to gcc 11.2 on Linux [v2]

2022-04-12 Thread Kevin Rushforth
> This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Kevin Rushforth has updated the pull request with a new target b

Integrated: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

2022-04-12 Thread Kevin Rushforth
On Sat, 2 Apr 2022 17:34:46 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2022 version 17.1.0 on > Windows, in order to match JDK 19 -- see > [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). > > I ran a full build and test, incl

Re: Xlib backend

2022-04-11 Thread Kevin Rushforth
Can you say more about the motivation for doing this? Given the eventual direction for Wayland support, even in X11 compatibility mode, I would expect more use of gtk and less use of Xlib, not the other way around. -- Kevin On 4/10/2022 2:43 PM, Thiago Milczarek Sayão wrote: Hi, I got simple

Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ [v2]

2022-04-07 Thread Kevin Rushforth
On Thu, 7 Apr 2022 09:55:36 GMT, Jay Bhaskar wrote: >> Issue: Floating point overflow , when making end point for line drawing as >> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); >> Solution: traverse widths to calculate end point and increment start point. > > Jay Bhaskar has

Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/

2022-04-06 Thread Kevin Rushforth
On Sat, 2 Apr 2022 08:29:43 GMT, Jay Bhaskar wrote: > Issue: Floating point overflow , when making end point for line drawing as > FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); > Solution: traverse widths to calculate end point and increment start point. I instrumented the co

Re: RFR: 8281723: Spinner with split horizontal arrows and a border places right arrow incorrectly [v2]

2022-04-06 Thread Kevin Rushforth
On Wed, 9 Mar 2022 07:48:53 GMT, John Hendrikx wrote: >> I added a test case for `SpinnerSkin` that checks the arrow positioning. >> >> While adding the tests I discovered more problems with the positioning aside >> from the one mentioned in the JBS ticket. >> >> 1) Vertical split arrow placem

Re: RFR: 8282054: Mediaplayer not working with HTTP Live Stream link with query parameter appended with file extension m3u8

2022-04-06 Thread Kevin Rushforth
On Fri, 11 Mar 2022 03:01:39 GMT, Alexander Matveev wrote: > - Problem was that our code which checks if URI ends with file extension was > not considering that URI can have query parameters. Fixed by checking URI > path, instead of actual URI. > - Also, creation of HLS Connection holder was m

Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

2022-04-05 Thread Kevin Rushforth
On Mon, 4 Apr 2022 11:14:27 GMT, Joeri Sykora wrote: > Which versions were chosen for the build tools, redistributables and the CRT? > Do we still use the same ones as with Visual Studio 2019? Each version of Visual Studio has its own set of compilers and redistributables. Visual Studio 2022 v

Re: RFR: 8281564: Update cmake to 3.22.3

2022-04-05 Thread Kevin Rushforth
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. Looks good. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/767

Re: RFR: 8193442: Removing TreeItem from a TreeTableView sometime changes selectedItem

2022-04-04 Thread Kevin Rushforth
On Mon, 14 Mar 2022 14:49:41 GMT, Jose Pereda wrote: > This PR fixes > JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also > [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and verifies > that the tests mentioned in > [JDK-8088157](https://bugs.openjdk.j

RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

2022-04-02 Thread Kevin Rushforth
This patch updates the compiler to Visual Studio 2022 version 17.1.0 on Windows, in order to match JDK 19 -- see [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). I ran a full build and test, including media and WebKit. - Commit messages: - 8283786: Update to Visual

Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/

2022-04-02 Thread Kevin Rushforth
On Sat, 2 Apr 2022 08:29:43 GMT, Jay Bhaskar wrote: > Issue: Floating point overflow , when making end point for line drawing as > FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); > Solution: traverse widths to calculate end point and increment start point. I'll take a closer lo

Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]

2022-04-01 Thread Kevin Rushforth
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue with the release 2.9.13, as m

Re: RFR: 8283328: Update libxml2 to 2.9.13

2022-04-01 Thread Kevin Rushforth
On Thu, 31 Mar 2022 14:47:32 GMT, Hima Bindu Meda wrote: > We currently use libxml2 version 2.9.12. It should be updated to latest > stable release, which is version 2.9.13. > The steps to update libxml are documented in UPDATING.txt. > There is compilation issue with the release 2.9.13, as ment

Re: Self built openjfx 17.0.2

2022-03-30 Thread Kevin Rushforth
No. What you want is the jfx17u repo. https://github.com/openjdk/jfx17u/tree/master If you look at the tags you will see 17.0.2+3 is the latest (GA) sources. -- Kevin On 3/30/2022 12:23 PM, Thiago Milczarek Sayão wrote: Hi, Does the "jfx17" branch contain the latest javafx 17.0.2 code ? htt

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v4]

2022-03-30 Thread Kevin Rushforth
On Wed, 30 Mar 2022 12:22:23 GMT, Robert Lichtenberger wrote: >> This fix respects a row factory, if present. >> It will put the cell that is used to measure the column width as child below >> the row. >> In that way the row's style will be used. > > Robert Lichtenberger has updated the pull re

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v2]

2022-03-30 Thread Kevin Rushforth
On Wed, 30 Mar 2022 10:57:38 GMT, Robert Lichtenberger wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java >> line 715: >> >>> 713: tableRow = createMeasureRow(tv, tableSkin, null); >>> 714: } >>> 715: assert tableRow.get

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-30 Thread Kevin Rushforth
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Given

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Kevin Rushforth
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit.

Integrated: 8283517: Update boot JDK to 18

2022-03-29 Thread Kevin Rushforth
On Fri, 25 Mar 2022 12:16:18 GMT, Kevin Rushforth wrote: > JDK 18 has been released, so we should update the default boot JDK used to > build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I > have confirmed that gradle 7.3 works with JDK 18, so we don't

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Kevin Rushforth
On Tue, 29 Mar 2022 11:49:14 GMT, Kevin Rushforth wrote: >> .github/workflows/submit.yml line 86: >> >>> 84: set -x >>> 85: sudo apt-get update >>> 86: sudo apt-get install libgl1-mesa-dev libx11-dev >>> libxxf86vm

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Kevin Rushforth
On Tue, 29 Mar 2022 09:42:38 GMT, Johan Vos wrote: >> This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK >> 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). >> >> I ran a full build and test, including media and WebKit. > > .github/workflows/su

Re: Is it wise to use JavaFX 18 with JDK 17?

2022-03-28 Thread Kevin Rushforth
Given that JavaFX is unbundled, and that JavaFX N released at or slightly before the JDK N, you can always use JavaFX N with JDK N-1 or later. We haven't bumped the minimum JDK version needed to run JavaFX for quite some time, which as noted, remains at JDK 11. I expect we will change the min

Re: RFR: 8280369: native library cache should be platform/arch specific

2022-03-25 Thread Kevin Rushforth
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > > Mos

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v3]

2022-03-25 Thread Kevin Rushforth
On Thu, 24 Mar 2022 10:06:34 GMT, Johan Vos wrote: >> When the size of a ListCell is changed and a scrollTo method is invoked >> without having a layout calculation in between, the old (wrong) size is used >> to calculcate the total estimate. This happens e.g. when the size is changed >> in th

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-25 Thread Kevin Rushforth
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. > Thi

RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-25 Thread Kevin Rushforth
This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). I ran a full build and test, including media and WebKit. - Commit messages: - 8283402: Update to gcc 11.2 on Linux Changes: https:

RFR: 8283517: Update boot JDK to 18

2022-03-25 Thread Kevin Rushforth
JDK 18 has been released, so we should update the default boot JDK used to build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I have confirmed that gradle 7.3 works with JDK 18, so we don't need to update gradle at this time. I have done a full set of tests on all three

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-24 Thread Kevin Rushforth
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux, sinc

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-23 Thread Kevin Rushforth
On Tue, 22 Mar 2022 08:54:45 GMT, Johan Vos wrote: > I wonder if we can add some simple resources that allow testing the different > protocols on different platforms? I can't think of a good way to do that, especially for this feature, since it requires a web server. - PR: https:

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-23 Thread Kevin Rushforth
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux, sinc

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread Kevin Rushforth
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This w

Re: RFR: 8236689: macOS 10.15 Catalina: LCD text renders badly

2022-03-19 Thread Kevin Rushforth
On Tue, 15 Mar 2022 18:13:15 GMT, Mike Hearn wrote: >> On an external (non-retina) monitor JavaFX LCD text on macOS is painful on >> the eyes. >> Retina diminishes it rather than cures it. >> >> The problem is a mix of a couple of things >> 1) CoreText no longer generates LCD glyphs (except per

Re: Question about fatal JavaFX crashes

2022-03-18 Thread Kevin Rushforth
Thanks, Phil. That was my take as well. I don't see how this can be a JavaFX bug given where it is crashing. FWIW, I haven't ever seen anything like this. -- Kevin On 3/18/2022 10:25 AM, Philip Race wrote: I think it is probable that this is a hotspot VM problem in the C2 JIT compiler code.

Integrated: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-16 Thread Kevin Rushforth
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) >

Re: RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-03-16 Thread Kevin Rushforth
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. I was able to

Re: RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-03-16 Thread Kevin Rushforth
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. There are two

Re: RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-16 Thread Kevin Rushforth
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) >

Re: RFR: 8283246: WebKit fails to build on Linux

2022-03-16 Thread Kevin Rushforth
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. Thanks for the

Odd Skara webrev email [was: Re: RFR: Merge jfx18 [v2]]

2022-03-15 Thread Kevin Rushforth
track what looks like a Skara PR bot bug. -- Kevin On 3/15/2022 4:22 PM, Kevin Rushforth wrote: Final merge of `jfx18` into `master`. Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought

Integrated: Merge jfx18

2022-03-15 Thread Kevin Rushforth
On Tue, 15 Mar 2022 22:41:14 GMT, Kevin Rushforth wrote: > Final merge of `jfx18` into `master`. This pull request has now been integrated. Changeset: 4afc8afc Author: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/4afc8afc42cb0afedd1b8d3d7b6ef0030603ba9f St

Re: RFR: Merge jfx18 [v2]

2022-03-15 Thread Kevin Rushforth
> Final merge of `jfx18` into `master`. Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 32 additional commits since the last revis

RFR: Merge jfx18

2022-03-15 Thread Kevin Rushforth
Final merge of `jfx18` into `master`. - Commit messages: - Merge jfx18 - 8282766: Create release notes for JavaFX 18 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jfx/pull/755/files Stats:

Re: RFR: 8193442: Removing TreeItem from a TreeTableView sometime changes selectedItem

2022-03-15 Thread Kevin Rushforth
On Mon, 14 Mar 2022 14:49:41 GMT, Jose Pereda wrote: > This PR fixes > JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also > [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and verifies > that the tests mentioned in > [JDK-8088157](https://bugs.openjdk.j

RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-15 Thread Kevin Rushforth
We continue to get intermittent test failures in `PredefinedMeshManagerTest` due to an OOM error. See the GitHub Actions run for [PR 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) for a recent failure. This test failure is tracked by [JDK-8282449](https://bugs.open

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Kevin Rushforth
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - s/Enhancement/Enhancements > - C

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Kevin Rushforth
On Mon, 14 Mar 2022 19:46:18 GMT, Abhinay Agarwal wrote: >>> @kevinrushforth Before I integrate the PR, can you have a look at [my >>> comment on the >>> issue](https://bugs.openjdk.java.net/browse/JDK-8282766?focusedCommentId=14482267&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomm

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Kevin Rushforth
On Mon, 14 Mar 2022 17:55:45 GMT, Thiago Milczarek Sayao wrote: >> Abhinay Agarwal has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additiona

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Kevin Rushforth
On Mon, 14 Mar 2022 13:31:34 GMT, Kevin Rushforth wrote: >> Abhinay Agarwal has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - s/Enhancement/Enhancements >> - Create release not

Re: [jfx18] RFR: 8282766: Create release notes for JavaFX 18 [v2]

2022-03-14 Thread Kevin Rushforth
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 18 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/reb

Re: RFR: 8282766: Create release notes for JavaFX 18

2022-03-12 Thread Kevin Rushforth
On Sat, 12 Mar 2022 10:18:07 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 18 to the repository I see that this is targeted to the `master` branch. It should be targeted to `jfx18`. Since your branch is based on `master` you will need to rebase your branch and force-push before ch

Re: RFR: 8282093: LineChart path incorrect when outside lower bound [v2]

2022-03-12 Thread Kevin Rushforth
On Tue, 1 Mar 2022 06:12:59 GMT, Abhinay Agarwal wrote: >> This regression was caused in PR #667 in which I didn't take into account >> the lower bounds. I have added more tests and one manual test along with the >> fix. The manual test can be used to identify any future issues with paths >> o

Re: RFR: 8282766: Create release notes for JavaFX 18

2022-03-12 Thread Kevin Rushforth
On Sat, 12 Mar 2022 10:18:07 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 18 to the repository Looks good other than one typo: Enhancement --> Enhancements doc-files/release-notes-18.md line 18: > 16: See [JDK-8273089](https://bugs.openjdk.java.net/browse/JDK-8273089) for > more

Re: RFR: 8282703: Axis is not cached in the LinuxTouchTransform class

2022-03-11 Thread Kevin Rushforth
On Fri, 11 Mar 2022 15:20:17 GMT, chilliger wrote: > Did I miss something? Is touch now support with GTK? I thought the > implementation is missing for GTK This PR is for Monocle, which is not used for desktop Linux (it's for embedded systems like Raspberry Pi). - PR: https://git

Re: Missing vcruntime140_1.dll

2022-03-10 Thread Kevin Rushforth
No, as mentioned in my recent reply (which was done after you sent this), the bug and ultimate solution was in JavaFX. See JDK-8281089 [1]. I also refer you to PR #734 [2] where this was discussed in detail. -- Kevin [1] https://bugs.openjdk.java.net/browse/JDK-8281089 [2] https://git.openjdk.

Re: Missing vcruntime140_1.dll

2022-03-10 Thread Kevin Rushforth
This was recently fixed by https://bugs.openjdk.java.net/browse/JDK-8281089 -- Kevin On 3/9/2022 11:44 PM, Julien DEHAUDT wrote: Hello, This thread is a follow-up of existing issue on Adoptium GitHub, see https://github.com/adoptium/adoptium-support/issues/307. In short we are in a dead end

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v2]

2022-03-09 Thread Kevin Rushforth
On Wed, 9 Mar 2022 05:20:00 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux, since

Re: RFR: 8230231: font-family not updated in HTMLEditor [v3]

2022-03-09 Thread Kevin Rushforth
On Wed, 21 Jul 2021 14:56:11 GMT, Hadzic Samir wrote: >> Fix for https://github.com/javafxports/openjdk-jfx/issues/573 >> >> Issue on JBS bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 >> >> Fix: Check for quote when updating the font-family comboBox. >> >> A new font is added

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-03-08 Thread Kevin Rushforth
On Fri, 4 Feb 2022 11:24:48 GMT, Alexander Matveev wrote: > - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. > - Added support for elementary AAC streams without any container for audio > only streams. > - Added "aacparse" plugin from GStreamer. Required on Linux, since deco

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v10]

2022-03-08 Thread Kevin Rushforth
On Tue, 8 Mar 2022 20:32:53 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindow

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-03-07 Thread Kevin Rushforth
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window = activeWindo

Re: RFR: 8255940: localStorage is null after window.close() [v9]

2022-03-07 Thread Kevin Rushforth
On Fri, 4 Mar 2022 16:55:48 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag

Re: Bug: ComboBox dropdown list of combobox is not taking Scale Transformation in consideration

2022-03-07 Thread Kevin Rushforth
This sounds like JDK-8088757 [1], "Scale of control does not cross to popup in popup-based controls". Yes, it does seems like a legitimate bug to me. Fixing it might result in a surprising behavior change for some existing applications, given how long this behavior has been in place (the bug in

Re: RFR: 8280020: Underline and line-through not straight in WebView [v8]

2022-03-07 Thread Kevin Rushforth
On Mon, 7 Mar 2022 09:28:52 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add thickne

Re: RFR: 8280840: Update libFFI to 3.4.2 [v2]

2022-03-05 Thread Kevin Rushforth
On Thu, 24 Feb 2022 03:07:57 GMT, Alexander Matveev wrote: >> LibFFI updated to 3.4.2. No additional changes to our code, libffi code or >> build system were required. Tested on all platforms. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since t

Re: RFR: 8282100: Missed top/left bouncing for ScrollPane on Raspberry Pi with Touchscreen

2022-03-05 Thread Kevin Rushforth
On Fri, 18 Feb 2022 15:21:49 GMT, Alexander Scherbatiy wrote: > There is the bouncing when scrolling a node on a ScrollPane to the > right/bottom (the node on the scroll pane is scrolled further than its > width/height so the background is visible and then automatically is scrolled > back to

Re: RFR: 8282702: Button is pressed one more time on Raspberry Pi with Touchscreen

2022-03-05 Thread Kevin Rushforth
On Sat, 5 Mar 2022 13:58:54 GMT, Alexander Scherbatiy wrote: > Tapping on a button and next tapping on another place on the screen leads > that the button is pressed twice on a Raspberry Pi with Touchscreen. > > For example, run the > [JFXButtonExample](https://bugs.openjdk.java.net/secure/at

Re: RFR: 8255940: localStorage is null after window.close() [v9]

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 16:55:48 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag

Re: RFR: 8255940: localStorage is null after window.close() [v8]

2022-03-04 Thread Kevin Rushforth
On Thu, 3 Mar 2022 17:08:49 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag

Re: RFR: 8269115: WebView paste event contains old data [v7]

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 02:50:24 GMT, Jay Bhaskar wrote: >> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and >> appending mime types in pasteboard operation like setPlainText, Hence it >> will append duplicate mime types in m_availMimeTypes , in this case the >> length clipboar

[jfx11u] Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-03-04 Thread Kevin Rushforth
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2) Changes: https://git.openjdk.java.net/jfx11u/pull/80/files Webrev

[jfx11u] Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 14:40:49 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. I tested this along with the other VS 2019 and > WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. This pull request has now been integrated. Changeset: 90a0ae22 Author: Kevin Rushfort

[jfx11u] Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 14:27:25 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. I tested this along with the other VS 2019 and > WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. This pull request has now been integrated. Changeset: eda64804 Author: Kevin Rushfort

[jfx11u] Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-03-04 Thread Kevin Rushforth
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8281711: Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx11u/pull/79/files Webrev: ht

[jfx11u] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 14:16:14 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. I tested this along with the other VS 2019 and > WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. This pull request has now been integrated. Changeset: 429f4181 Author: Kevin Rushfort

[jfx11u] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-03-04 Thread Kevin Rushforth
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8281459: WebKit 613.1 build broken on M1 Changes: https://git.openjdk.java.net/jfx11u/pull/78/files Webrev: https://webrevs

[jfx11u] Integrated: 8278980: Update WebKit to 613.1

2022-03-04 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch.

[jfx11u] Integrated: 8265399: Update to Visual Studio 2019 version 16.9.3

2022-03-04 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. This pull request has

Re: RFR: 8280020: Underline and line-through not straight in WebView [v7]

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 03:29:33 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add thickne

Re: [jfx11u] RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

2022-03-03 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. Pending a second reviewer.

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-03-02 Thread Kevin Rushforth
On Mon, 21 Feb 2022 02:41:13 GMT, Jay Bhaskar wrote: >> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line >> 75: >> >>> 73: this.primaryStage = primaryStage; >>> 74: this.primaryStage.setWidth(80); >>> 75: this.primaryStage.setHeight

Re: RFR: 8280020: Underline and line-through not straight in WebView [v6]

2022-03-02 Thread Kevin Rushforth
On Tue, 1 Mar 2022 03:24:57 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add thickne

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v4]

2022-03-01 Thread Kevin Rushforth
On Tue, 1 Mar 2022 06:19:04 GMT, Hima Bindu Meda wrote: >> Basically, buttons property is a mask which represents the button/buttons >> clicked on the mouse. >> It is observed that event.buttons property is set to 0 when there is >> mouse press or drag event.This behaviour is observed only

Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-02-28 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. @a

[jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-02-28 Thread Kevin Rushforth
Nearly clean backport to `jfx11u` (the only conflict was in the copyright years in one of the unit tests). I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8278980: Update WebKit to 613.1 Changes: htt

[jfx17u] Integrated: 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start

2022-02-28 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:14:18 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. I tested the backports of > [JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711), > [JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and > [JDK-82

Re: [jfx11u] RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

2022-02-28 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. This is a prerequisit

[jfx17u] RFR: 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start

2022-02-28 Thread Kevin Rushforth
Clean backport to `jfx17u`. I tested the backports of [JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711), [JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and [JDK-8281089](https://bugs.openjdk.java.net/browse/JDK-8281089) together in the `test-kcr-17.0.3` branch.

<    1   2   3   4   5   6   7   8   9   10   >