[8u82] review request: 8088397: [Dialog] ButtonType text not updated when Locale changes

Hi Kevin, Please review this backport to 8u-dev. https://bugs.openjdk.java.net/browse/JDK-8088397 http://cr.openjdk.java.net/~leifs/8088397/webrev.8u.00/ Compare to change in JDK 9: http://cr.openjdk.java.net/~leifs/8088397/webrev.00/

[9] Request for review: 8143158 [Text, TextFlow] Make public API from internal "impl" APIs

Hi Kevin, Please review the implementation of the new API. https://bugs.openjdk.java.net/browse/JDK-8143158 http://cr.openjdk.java.net/~leifs/8143158/webrev.01/ Thanks, Leif

Re: [9] Request for API review: 8143158 [Text, TextFlow] Make public API from internal "impl" APIs

Just a reminder. The proposed API for TextFlow is kept simple as described in JIRA. Thanks, Leif On 2015-11-29 16:30, Leif Samuelsson wrote: Kevin, Phil, et al, Please review the proposed new API for Text and TextFlow to open up existing internal methods for text selection, etc. Most

[9] Request for API review: 8143158 [Text, TextFlow] Make public API from internal "impl" APIs

Kevin, Phil, et al, Please review the proposed new API for Text and TextFlow to open up existing internal methods for text selection, etc. Most of the new Text API is simply renaming of formerly deprecated methods, while the TextFlow API is added to expose underlying layout functionality and

[9] Review request for 8139606: [MenuBar] Menus should activate on ALT released, not pressed, on Windows/Linux

Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8139606 http://cr.openjdk.java.net/~leifs/8139606/webrev.00/ Thanks, Leif

[9] Review request for 8133833: JavaFX HTMLEditor Font Family should not default to a platform-specific font.

Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8133833 http://cr.openjdk.java.net/~leifs/8133833/webrev.00/ Thanks, Leif

[9] Review request for 8088969: Ensemble8: HTML Editor's popup controls retain focus

Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8088969 http://cr.openjdk.java.net/~leifs/8088969/webrev.00/ Thanks, Leif

[9] Review request for 8088397: [Dialog] ButtonType text not updated when Locale changes

Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8088397 http://cr.openjdk.java.net/~leifs/8088397/webrev.00/ Thanks, Leif

[8u, 9] Review request: 8136838: [ComboBox, DatePicker] Value doesn't update when focus is lost

Hi Jonathan, Please review this fix for 8u72 and 9. https://bugs.openjdk.java.net/browse/JDK-8136838 http://cr.openjdk.java.net/~leifs/8136838/webrev-8u.00/ http://cr.openjdk.java.net/~leifs/8136838/webrev-9.00/ Thanks, Leif

Re: Regression or feature: editable comboBox doesn't commit on focus lost

This is a regression in 8u60. I have filed a new issue for this and I hope that we can backport a fix to an 8u release. https://bugs.openjdk.java.net/browse/JDK-8136838 Leif On 2015-09-21 06:38, faste...@swingempire.de wrote: short description (for a complete description and a workaround

Re: MenuBar in osx to set About, Preferences, Quit

See: https://bugs.openjdk.java.net/browse/JDK-8091517 https://bugs.openjdk.java.net/browse/JDK-8088585 Leif On 2015-09-02 10:10, Kevin Rushforth wrote: You can file an RFE at http://bugs.java.com/ -- Kevn jo...@msli.com wrote: I would love to file a bug, as this is really big hole for

[8u60, 9] Review request: RT-36454: [Modena, TextArea] Vertical scrollbar appears in TextArea and then disappears

Hi Jonathan, Please review this fix for TextArea. https://javafx-jira.kenai.com/browse/RT-36454 http://cr.openjdk.java.net/~leifs/rt36454/webrev.01/ Thanks, Leif

[8u60,9] Review request: RT-34620: [ComboBox, DatePicker] Buttons set to default/cancel are not reacting to ComboBox enter/esc keys

Hi Jonathan, Please review this fix. https://javafx-jira.kenai.com/browse/RT-34620 http://cr.openjdk.java.net/~leifs/rt34620/webrev.01/ Thanks, Leif

[8u60,9] Review request: RT-39804: Apostrophe as dead key doesn't work on Windows 8.1 Latvian (Standard) keyboard layout

Chien, Kevin, David, Please review this fix for Glass on Windows. https://javafx-jira.kenai.com/browse/RT-39804 http://cr.openjdk.java.net/~leifs/rt39804/webrev.01/ Thanks, Leif

[8u60,9] Review request: RT-39464: Polytonic displays incorrectly when typed in (via TextField)

Hi Chien and Kevin, Please review this fix for Glass on Windows. https://javafx-jira.kenai.com/browse/RT-39464 http://cr.openjdk.java.net/~leifs/rt39464/webrev.01/ Thanks, Leif

[8u] Review request: RT-40280 Refactor duplicated editor code in ComboBox and DatePicker skins.

Hi Jonathan, Please review this fix involving skins based on ComboBoListViewSkin. https://javafx-jira.kenai.com/browse/RT-40280 http://cr.openjdk.java.net/~leifs/rt40280/webrev.01/ Thanks, Leif

[8u] Review request: RT-39642: Selection on double click selects too much on Windows

Hi Jonathan, Please review this fix for TextInputControl on Windows. A simple patch is attached in JIRA. https://javafx-jira.kenai.com/browse/RT-39642 Thanks, Leif

[8u40] Review request for RT-38978: [ComboBox] Editable ComboBox doesn't handle IM events if it gets focus through focus traversal keys.

Hi Naoto and Jonathan, Please review this fix for ComboBox and DatePicker. Jira: https://javafx-jira.kenai.com/browse/RT-38978 Webrev: http://cr.openjdk.java.net/~leifs/rt38978/ Thanks, Leif

hg: openjfx/8u-dev/rt: RT-37092: (cont.) Revert workaround for test failure and fix StubTextLayout instead.

Changeset: e4d86f6cd678 Author:leifs Date: 2014-08-20 14:49 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e4d86f6cd678 RT-37092: (cont.) Revert workaround for test failure and fix StubTextLayout instead. Reviewed-by: fheidric !

hg: openjfx/8u-dev/rt: RT-37092: When I use 'Arial' or 'Hiragino Sans GB' font in a TextArea, the arrow 'Down' is not working well

Changeset: 0bec451a41d1 Author:leifs Date: 2014-08-19 11:50 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0bec451a41d1 RT-37092: When I use 'Arial' or 'Hiragino Sans GB' font in a TextArea, the arrow 'Down' is not working well Reviewed-by: fheidric !

hg: openjfx/8u-dev/rt: [TEST ONLY] Fix tests for RT-38012. The explicit TimeZone was not uniformly applied to all objects.

Changeset: 54d3f711ae54 Author:leifs Date: 2014-08-14 10:40 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/54d3f711ae54 [TEST ONLY] Fix tests for RT-38012. The explicit TimeZone was not uniformly applied to all objects. !

[8u40] Review request: RT-38011 StringConverter support for LocalDate/LocalTime/LocalDateTime

Hi Jonathan, Please review this fix which adds three new converter classes. https://javafx-jira.kenai.com/browse/RT-38011 http://cr.openjdk.java.net/~leifs/rt38011/webrev.02/ Thanks, Leif

[8u40] Review reequest: RT-38012 Date/time converters use unwanted format patterns

Hi Jonathan, Please review this fix which adds two new constructors to each of three converter classes. https://javafx-jira.kenai.com/browse/RT-38012 http://cr.openjdk.java.net/~leifs/rt38012/webrev.01/ Thanks, Leif

[8u20] Review request: RT-37271: User presentable strings for accessibility are not translatable

Hi Felipe, Please review this fix and verify if you can that the strings still appear as expected in the AT software you are testing with. https://javafx-jira.kenai.com/browse/RT-37271 http://cr.openjdk.java.net/~leifs/rt37271/webrev.01/ Thanks, Leif

[8u20] Review request: RT-36660: [TextField] Arrow scrolling movement unexpected when text overflows

Hi Jonathan, Please review. https://javafx-jira.kenai.com/browse/RT-36660 http://cr.openjdk.java.net/~leifs/rt36660/webrev.01/ Thanks, Leif

Re: Creating a type of toggle with two labels..

It seems to me that you could do this with a small class extending ToggleButton. Add a couple of String properties and use a selection listener to switch the main text value. You wouldn't need to write any skin or behavior classes, Just define the look in CSS and use -fx-label-padding to place

Re: Creating a type of toggle with two labels..

On 2013-12-04 14:54, Leif Samuelsson wrote: It seems to me that you could do this with a small class extending ToggleButton. Add a couple of String properties and use a selection listener to switch the main text value. You wouldn't need to write any skin or behavior classes, Just define

Review request: RT-34220 [Control, Text] arrow up / arrow down is wrong on TextArea

Hi Felipe, Please review fix for RT-34220: [Control, Text] arrow up / arrow down is wrong on TextArea. The fix description is in JIRA. https://javafx-jira.kenai.com/browse/RT-34220 http://cr.openjdk.java.net/~leifs/rt34220/ Thanks, Leif

Please review fix for RT-33416: Key traversal does not enter into an opened ScrollPane

Hi, Please review this fix for TitledPaneBehavior and ScrollPaneBehavior. The patch and details are in JIRA. https://javafx-jira.kenai.com/browse/RT-33416 Thanks, Leif

Re: Minor issue with ColorPicker

Good point (no pun intended). I'll address this when I move the string to the resource file for https://javafx-jira.kenai.com/browse/RT-34099. Leif On 2013-11-07 03:17, Felix Bembrick wrote: Why does the text Custom Color.. that appears when the colour selections appear in the drop-down

Review request: RT-34115: DatePicker: space is inserted into the textfield when pressing space to close the popup.

Hi Jonathan, A fix description and patch are in JIRA. https://javafx-jira.kenai.com/browse/RT-34115 Thanks, Leif