Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-10 Thread Kevin Rushforth
I added the missing copyright header before pushing. I will file two new issues: one to add copyright headers to all the other package.html files (which I will do in JDK 9) and one to convert all of the package.html files to package-info.java (which I will target to 10...I don't want to make th

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Mandy Chung
> On May 9, 2017, at 6:52 PM, Kevin Rushforth > wrote: > > Thanks for the review. We currently don't use package-info.java anywhere, but > I can file a separate bug for converting all of our package.html to > package-info.java. That’d be good. > I can add the the missing copyright headers a

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Kevin Rushforth
Thanks for the review. We currently don't use package-info.java anywhere, but I can file a separate bug for converting all of our package.html to package-info.java. I can add the the missing copyright headers at the same time. -- Kevin Mandy Chung wrote: On May 9, 2017, at 6:08 PM, Kevin Ru

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Mandy Chung
> On May 9, 2017, at 6:08 PM, Kevin Rushforth > wrote: > > Please review the following to exclude jdk.packager module from the JDK docs > bundle: > > https://bugs.openjdk.java.net/browse/JDK-8180040 > http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ > > I also added a missing package descr

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Erik Joelsson
Looks ok to me. /Erik On 2017-05-09 18:08, Kevin Rushforth wrote: Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package descripti

[9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Kevin Rushforth
Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package description for the jdk.packager.services package (in the jdk.packager.service