On Thu, 14 Nov 2019 09:33:39 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
> This PR is to address ignored tests in ComboBoxTest, LabeledTest, > HyperLinkTest and TextInputControlTest. > > strategy is as follows - > > 1) Enable tests marked with @Ignore by removing that tag > 2) Run the test > 3) If test Passes - remove the @Ignore tag > 4) If test fails - if test is invalid - remove it, else fix the test > 5) In case if the failure cannot be fixed, leave the test ignored (keep > @Ignore tag) > > > With these corrections - here are the results: > > Results BEFORE this FIX > 1. ComboBoxTest -- tests:156, failures:0, ignored:4 > 2. LabeledTest -- tests:93, failures:0, ignored:5 > 3. HyperlinkTest -- tests:34, failures:0, ignored:3 > 4. TextInputControlTest -- tests:594, failures:0, ignored:12 > > Results AFTER this FIX > 1. ComboBoxTest -- tests:156, failures:0, ignored:2 > 2. LabeledTest -- tests:93, failures:0, ignored:3 > 3. HyperlinkTest -- tests:31, failures:0, ignored:0 > 4. TextInputControlTest -- tests:585, failures:0, ignored:0 > > ---------------- > > Commits: > - 6709837b: Fix-Remove-Keep @Ignore tests > > Changes: https://git.openjdk.java.net/jfx/pull/36/files > Webrev: https://webrevs.openjdk.java.net/jfx/36/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8234150 > Stats: 63 lines in 4 files changed: 0 ins; 57 del; 6 mod > Patch: https://git.openjdk.java.net/jfx/pull/36.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/36/head:pull/36 Approved by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/36
