AW: [PATCH] Decrease Toolkit.firePulse allocation rate

2016-01-15 Thread Doswald Michael
On 1/14/16 8:09 PM, Jim Graham wrote: > How often are listeners added and removed? It might make more sense to > make them copy-on-write instead...? That is a good point. As far as I can see, every window adds a stage listener when it is shown and removes it if it is closed. Every scene adds/rem

Re: [PATCH] Decrease Toolkit.firePulse allocation rate

2016-01-14 Thread Jim Graham
How often are listeners added and removed? It might make more sense to make them copy-on-write instead...? ...jim On 1/14/16 4:52 AM, Doswald Michael wrote: While profiling a JavaFX application that runs on embedded hardware, I have found that the Toolkit.firePulse me

Re: [PATCH] Decrease Toolkit.firePulse allocation rate

2016-01-14 Thread Kevin Rushforth
Hi Michael, If you would like to file an RFE, that would be fine. Before you do, please see the following page on contributing to an OpenJDK project such as OpenJFX: http://openjdk.java.net/contribute/ In particular, we need a signed Oracle Contributor Agreement (OCA) from you before we can

[PATCH] Decrease Toolkit.firePulse allocation rate

2016-01-14 Thread Doswald Michael
While profiling a JavaFX application that runs on embedded hardware, I have found that the Toolkit.firePulse method creates more garbage than necessary. In an application that simply animates an object without doing much else, I see that the firePulse method allocates a fair amount of objects (