Re: [Rev 01] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-02-03 Thread Ambarish Rapte
On Mon, 3 Feb 2020 10:16:13 GMT, Nir Lisker wrote: >> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do >> not play backwards after being paused) has been split to deal with >> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not >> embedded](https://b

Re: [Rev 01] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-31 Thread Kevin Rushforth
On Fri, 31 Jan 2020 18:41:57 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > Looks good. @arapte can you be the second reviewer for this? - PR: https://git.openjdk.java.net/jfx/pull/98

Re: [Rev 01] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-31 Thread Kevin Rushforth
On Fri, 31 Jan 2020 18:42:06 GMT, Nir Lisker wrote: >> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do >> not play backwards after being paused) has been split to deal with >> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not >> embedded](https://

Re: [Rev 01] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-31 Thread Nir Lisker
On Fri, 31 Jan 2020 00:31:17 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > The fix looks fine, and all my testing looks good, too. I don't have a good > recommendation for the test...I'd go with whatever is easiest for jfx14 and > address it mor

Re: [Rev 01] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-31 Thread Nir Lisker
> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do > not play backwards after being paused) has been split to deal with > [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not > embedded](https://bugs.openjdk.java.net/browse/JDK-8237975) animations. This