On Thu, 16 Apr 2020 11:23:24 GMT, Ambarish Rapte wrote:
>>> 1. do nothing for a (don't feel like filing yet another bug around
>>> selection ;) and b (the skin behaves correctly, I
>>> think)
>>
>> I am good with this. Though I will file a JBS for the correction in
>> ChoiceBoxSelectio
On Thu, 16 Apr 2020 11:18:55 GMT, Ambarish Rapte wrote:
>> btw: just noticed that there are methods in ChoiceBoxSkin testing the fix
>> for next/prev
>>
>> @Test public void test_jdk_8988261_selectNext() {
>> @Test public void test_jdk_8988261_selectPrevious() {
>>
>> the name look lik
On Thu, 16 Apr 2020 09:17:19 GMT, Jeanette Winzenburg
wrote:
>> yeah, you are right:
>>
>> a) the implementation of ChoiceBoxSelectionModel is broken when it comes to
>> handling of unselectable items (such as
>> Separator): next/previous try to move on, the others simply select. The
>> imple
On Thu, 16 Apr 2020 09:05:12 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ChoiceBoxSkin.java
>> line 416:
>>
>>> 415: } else {
>>> 416: toggleGroup.selectToggle(null);
>>> 417: }
>>
>> Th
On Wed, 15 Apr 2020 15:52:13 GMT, Ambarish Rapte wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ChoiceBox: added FIXME with reference to issue
>
> modules/javafx.controls/src/main/java/javafx/scene/control/
On Wed, 15 Apr 2020 15:46:16 GMT, Ambarish Rapte wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ChoiceBox: added FIXME with reference to issue
>
> modules/javafx.controls/src/main/java/javafx/scene/control/
On Wed, 15 Apr 2020 10:02:47 GMT, Jeanette Winzenburg
wrote:
>> Macroscopic issue is that initially, the toggle is not sync'ed to the
>> selection state. Root reason is an missing else
>> block when updating toggle selection state (see report for details).
>> Fixed by introducing the else block
On Wed, 15 Apr 2020 10:02:47 GMT, Jeanette Winzenburg
wrote:
>> Macroscopic issue is that initially, the toggle is not sync'ed to the
>> selection state. Root reason is an missing else
>> block when updating toggle selection state (see report for details).
>> Fixed by introducing the else block
On Tue, 14 Apr 2020 14:09:13 GMT, Ajit Ghaisas wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ChoiceBox: added FIXME with reference to issue
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Ch
> Macroscopic issue is that initially, the toggle is not sync'ed to the
> selection state. Root reason is an missing else
> block when updating toggle selection state (see report for details).
> Fixed by introducing the else block and removing all follow-up errors that
> tried to amend the conseq
10 matches
Mail list logo
