Re: [Rev 02] RFR: 8217472: Add attenuation for PointLight

2020-01-03 Thread Nir Lisker
On Fri, 3 Jan 2020 22:23:29 GMT, Kevin Rushforth wrote: >> I was wondering about it myself, but all the other values are `double`s that >> are cast to `float`s. Wouldn't it also be odd to have the API properties >> `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of >> whe

Re: [Rev 02] RFR: 8217472: Add attenuation for PointLight

2020-01-03 Thread Nir Lisker
On Fri, 3 Jan 2020 22:37:06 GMT, Kevin Rushforth wrote: >> I have added few comments, but have not run tests and sample yet. > >> I still need to test your sample app on Mac. > > I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04) > with the same error as I reported a

Re: [Rev 02] RFR: 8217472: Add attenuation for PointLight

2020-01-03 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 The pull request has been updated with 1 additional commit. - Added commits: - 464e8b5d: Fixed shader compilation errors for 2 and 3 lights in es2 Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https