Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-04-08 Thread Kevin Rushforth
On Sun, 29 Mar 2020 00:38:20 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to remove annoying warnings. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Sep cppFlags and cFlags The build changes in

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-04-07 Thread Kevin Rushforth
On Tue, 31 Mar 2020 20:45:44 GMT, Thiago Milczarek Sayao wrote: >> I took a look yesterday and came to the same conclusion that what we really >> want are separate C and C++ flags. For now, >> the only difference would be the presence or absence of >> `-Werror=implicit-function-declaration`,

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-31 Thread Thiago Milczarek Sayao
On Thu, 26 Mar 2020 11:21:06 GMT, Kevin Rushforth wrote: >> I think it's better to split the flags between CFLAGS and CPPFLAGS (as is >> done in OpenJDK). The >> `-Werror=implicit-function-declaration` is extremely useful for C files, and >> we don't want to risk that this somehow >> got lost.

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-28 Thread Thiago Milczarek Sayao
> Simple fix to remove annoying warnings. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Sep cppFlags and cFlags - Changes: - all: https://git.openjdk.java.net/jfx/pull/150/files - new: