Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.

2020-05-12 Thread Kevin Rushforth
On Tue, 12 May 2020 12:03:36 GMT, Tom Schindl wrote: >> Looks good to me. I verified that the new test fails without your fix and >> passes with your fix. >> >> In case anyone else is looking at this and wants to run the test, it isn't >> enabled by default, so you need to run it >> like

Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.

2020-05-12 Thread Tom Schindl
On Tue, 28 Apr 2020 22:36:47 GMT, Kevin Rushforth wrote: >> Tom Schindl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8202296: Monocle MouseInput doesn't send keyboard modifiers in events. >> >> Fix whitespace errors > > Looks

Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.

2020-04-28 Thread Kevin Rushforth
On Wed, 15 Apr 2020 08:28:22 GMT, Tom Schindl wrote: >> Extract keystate and add to the existing modifier mask, to support eg >> multi-select >> >> https://bugs.openjdk.java.net/browse/JDK-8202296 > > Tom Schindl has updated the pull request incrementally with one additional > commit since the

Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.

2020-04-15 Thread Tom Schindl
> Extract keystate and add to the existing modifier mask, to support eg > multi-select > > https://bugs.openjdk.java.net/browse/JDK-8202296 Tom Schindl has updated the pull request incrementally with one additional commit since the last revision: 8202296: Monocle MouseInput doesn't send