Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

2022-02-09 Thread Ajit Ghaisas
On Wed, 9 Feb 2022 13:34:13 GMT, Nir Lisker wrote: >> Good suggestion. >> >> Also optional, you can remove the `` since they are not needed for the >> initial paragraph. > > There are many redundant `` tags in the property docs too if you want to > deal with them as well for consistency (not i

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

2022-02-09 Thread Nir Lisker
On Wed, 9 Feb 2022 13:17:14 GMT, Kevin Rushforth wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line >> 738: >> >>> 736: >>> 737: /** >>> 738: * This specifies how the {@code TabPane} handles tab closing >>> from an end-user's >> >> Since you are f

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

2022-02-09 Thread Kevin Rushforth
On Wed, 9 Feb 2022 13:06:58 GMT, Nir Lisker wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line > 738: > >> 736

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

2022-02-09 Thread Nir Lisker
On Wed, 9 Feb 2022 07:32:20 GMT, Ajit Ghaisas wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line >> 295: >> >>> 293: * >>> 294: * This value can also be set via CSS using {@code >>> -fx-tab-min-width}. >>> 295: * >> >> I would write >> >> T

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

2022-02-09 Thread Nir Lisker
On Wed, 9 Feb 2022 09:39:46 GMT, Ajit Ghaisas wrote: >> This is a Javadoc cleanup and correction fix for the TabPane as described in >> the JBS. >> >> Changes done for all the Properties of the TabPane - >> - Moved the property description to be over the property field. >> - Removed the unneces

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

2022-02-09 Thread Ajit Ghaisas
> This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary docs on property setter/getter and Property method. Aji