Re: ACTION - JavaFX modular build is here

2016-11-09 Thread Kevin Rushforth
Yes, it is somewhat tricky to add a new qualified export. I would expect that to be rare. For JDK 9 let's go with the public API since it will be fewer moving parts. -- Kevin Laurent Bourgès wrote: Kevin & David, It seems tricky to add a module dependency ! 2016-11-09 14:51 GMT+01:00 Kevin

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread Laurent Bourgès
Kevin & David, It seems tricky to add a module dependency ! 2016-11-09 14:51 GMT+01:00 Kevin Rushforth : > My recommendation would be to avoid this dependency if possible, but if > not, then Dave's suggestion is the way to go. What is it that you need from > jdk.internal.ref that you can't do us

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread Kevin Rushforth
My recommendation would be to avoid this dependency if possible, but if not, then Dave's suggestion is the way to go. What is it that you need from jdk.internal.ref that you can't do using public API? -- Kevin David Hill wrote: On 11/9/16, 4:30 AM, Laurent Bourgès wrote: Any workaround ?

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread David Hill
On 11/9/16, 4:30 AM, Laurent Bourgès wrote: Any workaround ? PS: as you recommended me for Marlin JavaFX, I am trying adding a dependencies on modules: openjfx9/dependencies/java.base/module-info.java.extra: 27d26 < exports jdk.internal.ref to javafx.graphics; What is the magic to make cross-r

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread David Hill
On 11/9/16, 4:30 AM, Laurent Bourgès wrote: Nice catch. Points out that I should have tried a fully open build path. I did try several times an open JFX build, but each time I was using a commercial JDK. Kevin will push a fix today. Dave Hi david, I am trying to build OpenJDK9 with OpenJFX9

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread Kevin Rushforth
I will file a bug and fix this morning. I almost did yesterday as cleanup (we no longer use it even for the closed build). -- Kevin Laurent Bourgès wrote: Hi david, I am trying to build OpenJDK9 with OpenJFX9 (tip); I run the following scenario: - build OpenJFX9 with JDK9 EA 143: ok - build

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread Laurent Bourgès
Hi david, I am trying to build OpenJDK9 with OpenJFX9 (tip); I run the following scenario: - build OpenJFX9 with JDK9 EA 143: ok - build OpenJDK9 with --with-import-modules=_path_to_openjfx/9-dev/build/modular-sdk: ok - build OpenJFX9 with the built OpenJDK9: KO (gradle clean all) Apparently, the

Re: ACTION - JavaFX modular build is here

2016-11-08 Thread David DeHaven
> The new modular build has been committed to 9-dev !!! And you've just made my job about 100x easier! Huge thanks! -DrD-

ACTION - JavaFX modular build is here

2016-11-08 Thread David Hill
The new modular build has been committed to 9-dev !!! To ensure a continued happy development, please consider the following advice :-) Clean up your old repository before syncing. gradle clean consider (but not required) hg purge --all unset JIGSAW_HOME # this enviroment variable is n