Re: EM Font Size Performance

2019-03-26 Thread Dean Wookey
I've made what I've believe to be a cleaner fix here: https://github.com/DeanWookey/openjdk-jfx/commit/295a3e136c59eb661021de7b4c7ead8bd36a749a I'm not sure exactly how to proceed from here. I submitted a bug report several weeks ago so that I could submit a pull request against it, but I've

Re: EM Font Size Performance

2019-01-18 Thread Dean Wookey
I've only tested with our application that includes all those things. We set a font size on the root node and everything is done in em. The user can change the font size of the root node, which filters down to things like tooltips, context menus, tables etc. Do you know if there are tests

Re: EM Font Size Performance

2019-01-17 Thread David Grieve
I think the change looks reasonable. Has it been tested against things like changing -fx-font in some parent, or setting the font property in some parent? What about popups? If I have a tooltip on a Label, for example, does the tooltip properly pick up font from the Label's style or font

Re: EM Font Size Performance

2019-01-17 Thread Dean Wookey
This is almost a year old, but I think I've found a partial solution (David's suggestions on a top down approach still make sense, but that's a bigger issue). Caching an uncached call to lookupFont definitely improves performance.

Re: EM Font Size Performance

2018-04-19 Thread David Grieve
I was thinking about https://bugs.openjdk.java.net/browse/JDK-8177635 and https://bugs.openjdk.java.net/browse/JDK-8090462 There is also https://bugs.openjdk.java.net/browse/JDK-8187955 On 4/19/18 3:02 PM, Nir Lisker wrote: I think this is the issue:

Re: EM Font Size Performance

2018-04-19 Thread Nir Lisker
I think this is the issue: https://bugs.openjdk.java.net/browse/JDK-8088615. There's also https://bugs.openjdk.java.net/browse/JDK-8193445. - Nir On Thu, Apr 19, 2018 at 1:42 PM, David Grieve wrote: > Resolving the relative size involves a lot of lookup. You have to go

Re: EM Font Size Performance

2018-04-19 Thread David Grieve
Resolving the relative size involves a lot of lookup. You have to go up the scene-graph from the child to find a font style. If you get to the root and haven't found a font style, then use the default font. Performance in this area could be vastly improved by passing the size from either a

EM Font Size Performance

2018-04-19 Thread Dean Wookey
Hi All, In our application we add and remove a lot of nodes to the scene graph regularly, and also make use of em font sizes to scale certain parts of our application. We've noticed performance issues when adding nodes to the scene, and it seems to be related to em sizes in our css. As a test we