Re: JEP 253 webrev ready for review

I am going to give this a "+1" to go in, with the caveat that the API still needs a final review before being approved. There value in integrating this to main line both to get feedback and also unblock various other activities that are stalled waiting for this refactoring. Jonathan will

Re: JEP 253 webrev ready for review

What certainly should be factored out to be reusable is the CSS-Graphics-Property-Stuff because it does quite some magic! Tom On 05.09.15 21:44, Hendrik Ebbers wrote: > Sounds perfect. I think a SPI based plugin structure would be perfect. > > Cheers, > > Hendrik > > Von meinem iPhone

Re: JEP 253 webrev ready for review

It seems to be a very good idea! Sent from my iPad > On 4 sept. 2015, at 07:25, Jonathan Giles wrote: > > For what it's worth, I think enabling this is a really good idea. The > starting point is StyleConverter.java - it currently just hard codes all > available

Re: JEP 253 webrev ready for review

Let me comment on the examples you picked. The 1st and 2nd rely on the default skin being used (they lookup a node based on style class and then cast it to the expected type). This code would not work with a custom skin. The 3rd and 5th actually don't need skin implementations to be public,

Re: JEP 253 webrev ready for review

Hi Jonathan, regarding skins, while I don't see anything immediately wrong with the published API, I have trouble seeing how making skin implementations public is going to be useful. In particular, the JEP states that one of the success metrics is Projects that depend on JavaFX internal APIs, in

Re: JEP 253 webrev ready for review

Tomas, The webrev has a few examples of how skins being public will help. There are many more of such cases when you take into account the large number of projects I surveyed, but I just picked out the first few from this webrev for Scene Builder. The short answer is: if skins aren't public,

Re: JEP 253 webrev ready for review

I am trying to mentally digest the CSS API, but I am having trouble answering the question of whether or not the following scenario is now possible (using only public APIs). Imagine one wanted to create a new class that was analogous to DeriveColorConverter.java, and that it worked "all the way

Re: JEP 253 webrev ready for review

This is not in the spec for this jep. It is additional API that we can discuss and target for a release however. I highly recommend filling an issue in jbs for this, if one doesn't anyway exist. Thanks! -- Jonathan Sent from a touch device. Please excuse my brevity. On 4 September 2015

Re: JEP 253 webrev ready for review

For what it's worth, I think enabling this is a really good idea. The starting point is StyleConverter.java - it currently just hard codes all available converters. Making that pluggable won't be too difficult. If you (or anyone else) is interested in looking into this, we can discuss further.

JEP 253 webrev ready for review

Hi folks. For those of you interested in JEP 253 we've got some light weekend reading lined up for you. We are at a point where the JEP is basically ready to merge back into a mainline (public) repo, and out of its sandbox. Before we do that, we want any additional feedback from the