[10] Review request : JDK-8188164 : Visual glitch / layout issue when setting pref height of table column headers

2017-10-19 Thread Ajit Ghaisas
Hi, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK- 8188164 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8188164/webrev.0/ Regards, Ajit

Re: Layout issue

2014-02-12 Thread Tomas Mikula
Hi John, I'm replying to your question from JIRA: > Is there perhaps a better place to hook into when you want to have a > chance to update the layout as a result of deferred property changes? I took your example and modified it: https://gist.github.com/TomasMikula/6c5d97edc51ec8fa3d9e Perhaps

Re: Layout issue

2014-02-12 Thread John Hendrikx
On 11/02/2014 21:09, Martin Sladecek wrote: The rule of thumb in case you modify content during the layout is that content should depend on layout pane size, not the other way around. It means that changing the content won't modify the min/pref/max size of the pane as that would trigger another

Re: Layout issue

2014-02-12 Thread John Hendrikx
I've tried to create a simple test application in https://javafx-jira.kenai.com/browse/RT-35830. It is still fairly long, but it shows the problem right from the start when the Stage pops up. Thanks :) --John On 11/02/2014 20:41, Jonathan Giles wrote: If you can create a simple test applica

Re: Layout issue

2014-02-11 Thread Martin Sladecek
The rule of thumb in case you modify content during the layout is that content should depend on layout pane size, not the other way around. It means that changing the content won't modify the min/pref/max size of the pane as that would trigger another layout pass (possibly falling into a loop).

Re: Layout issue

2014-02-11 Thread Jonathan Giles
If you can create a simple test application it would be great if you can log this as a Jira issue so that we can take a proper look into this for you. Thanks, -- Jonathan On Wednesday, 12 February 2014 5:50:15 a.m., John Hendrikx wrote: > From an earlier posting on this list, I came to understa

Layout issue

2014-02-11 Thread John Hendrikx
From an earlier posting on this list, I came to understand that in JavaFX 8 it is no longer allowed to modify the children list in layoutChildren, and that such modifications may need to be moved to the computerPref* methods. However, I get a different odd issue, and I'm wondering exactly what