Re: RFR: 8089913: CSS styling problem with Slider pseudo classes

2021-03-05 Thread mstr2
On Fri, 5 Mar 2021 01:24:09 GMT, Kevin Rushforth wrote: >> side note: there might be a similar issue in other controls, f.i. the >> pseudoState of ListView orientation doesn't seem to be initialized > > The fix and test look good. > > @kleopatra Good catch about the same problem occurring in ot

Re: RFR: 8089913: CSS styling problem with Slider pseudo classes [v4]

2021-03-05 Thread mstr2
> The Slider control does not have the ":horizontal" CSS pseudo-class set by > default. The pseudo-class is only set once the "orientation" property is > changed. This PR fixes that. mstr2 has updated the pull request incrementally with two additional commits since the last revision: - Fixed

Re: RFR: 8089913: CSS styling problem with Slider pseudo classes [v3]

2021-03-05 Thread mstr2
> The Slider control does not have the ":horizontal" CSS pseudo-class set by > default. The pseudo-class is only set once the "orientation" property is > changed. This PR fixes that. mstr2 has updated the pull request incrementally with three additional commits since the last revision: - Fix

Re: RFR: 8089913: CSS styling problem with Slider pseudo classes

2021-03-04 Thread Kevin Rushforth
On Wed, 3 Mar 2021 16:40:27 GMT, Jeanette Winzenburg wrote: >> @mstr2 can you enable pre-submit testing for your repo as indicated the >> Checks section? You might need to then push a new (empty) commit to your >> branch in order to trigger the tests to run. > > side note: there might be a sim

Re: RFR: 8089913: CSS styling problem with Slider pseudo classes

2021-03-03 Thread Jeanette Winzenburg
On Wed, 3 Mar 2021 14:35:24 GMT, Kevin Rushforth wrote: >> The Slider control does not have the ":horizontal" CSS pseudo-class set by >> default. The pseudo-class is only set once the "orientation" property is >> changed. This PR fixes that. > > @mstr2 can you enable pre-submit testing for your

Re: RFR: 8089913: CSS styling problem with Slider pseudo classes [v2]

2021-03-03 Thread mstr2
> The Slider control does not have the ":horizontal" CSS pseudo-class set by > default. The pseudo-class is only set once the "orientation" property is > changed. This PR fixes that. mstr2 has updated the pull request incrementally with one additional commit since the last revision: Empty co

Re: RFR: 8089913: CSS styling problem with Slider pseudo classes

2021-03-03 Thread Kevin Rushforth
On Fri, 26 Feb 2021 15:17:23 GMT, mstr2 wrote: > The Slider control does not have the ":horizontal" CSS pseudo-class set by > default. The pseudo-class is only set once the "orientation" property is > changed. This PR fixes that. @mstr2 can you enable pre-submit testing for your repo as indic

RFR: 8089913: CSS styling problem with Slider pseudo classes

2021-03-03 Thread mstr2
The Slider control does not have the ":horizontal" CSS pseudo-class set by default. The pseudo-class is only set once the "orientation" property is changed. This PR fixes that. - Commit messages: - 8089913: CSS styling problem with Slider pseudo classes - Failing test Changes: ht