On Mon, 6 Sep 2021 11:05:42 GMT, Jose Pereda wrote:
>> I don't doubt that the area should be cleared. What I was questioning is
>> whether this was the best place to do it? I'd be OK with it if you document
>> it.
>
> The two options I see so far to clear the area are the one I've committed
>
On Fri, 3 Sep 2021 21:11:48 GMT, Kevin Rushforth wrote:
>> I guess the assumption might be the other way around? Since the fill color
>> was not transparent, there was no need to clear the area, when rendering the
>> same solid rect at the new position?
>>
>> If you check this
>>
On Fri, 27 Aug 2021 17:34:25 GMT, Jose Pereda wrote:
>> I'm more worried about correctness than performance. Setting a clip does not
>> necessarily imply that the clipped region should be cleared. So this feels a
>> bit like a workaround for a missing `clearRect` elsewhere. I wonder if there
On Fri, 27 Aug 2021 13:05:24 GMT, Kevin Rushforth wrote:
>> Initially, this was needed when there was some level of transparency: when
>> scrolling the old content was not cleared and you could see it at its old
>> position.
>>
>> For the full transparency case, this is still the case, but
On Fri, 27 Aug 2021 13:06:18 GMT, Kevin Rushforth wrote:
>> Yes, that makes total sense.
>>
>> In fact, there was also the need to add a new
>> [method](https://github.com/openjdk/jfx/pull/563/files#diff-b80bc720bf639cde38c5197a7619561221abcd34fb9ff7a933f4b932a1f36735R2579)
>> in `WebPage`
On Fri, 27 Aug 2021 09:32:24 GMT, Jose Pereda wrote:
>> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java
>> line 459:
>>
>>> 457: public void setClip(WCRectangle c) {
>>> 458: if (!isOpaque) {
>>> 459: clearRect((int)c.getX(),
On Wed, 25 Aug 2021 23:24:35 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 615:
>
>> 613:
On Wed, 25 Aug 2021 23:23:00 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java
>
On Wed, 25 Aug 2021 23:49:10 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 733:
>
>> 731:
On Wed, 25 Aug 2021 23:20:37 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2Graphics.java line
> 70:
>
>>
On Wed, 25 Aug 2021 23:32:47 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 708:
>
>> 706: *
>>
On Tue, 24 Aug 2021 22:12:01 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
On Tue, 24 Aug 2021 22:12:01 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the
14 matches
Mail list logo
