On Wed, 8 Sep 2021 21:08:40 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback from reviewers
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 2589:
>
>>
On Wed, 8 Sep 2021 22:37:18 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 707:
>>
>>> 705: * level of transparency.
>>> 706: *
>>> 707: * However, if the HTML content being loaded sets its own
>>
>> I looked at the generated
On Wed, 8 Sep 2021 16:15:36 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
On Wed, 8 Sep 2021 21:10:27 GMT, Kevin Rushforth wrote:
> I looked at the generated javadoc and this will read better without a
> paragraph break.
When you remove the paragraph break, please also remove the blank line to make
it clearer to future readers of the code that it is intended to be
On Wed, 8 Sep 2021 16:15:36 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the
