Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-22 Thread Marius Hanl
On Fri, 22 Oct 2021 10:15:59 GMT, Jeanette Winzenburg wrote: >> darn .. ;) Thanks > > hmm .. I'm all for consistency, so don't mind trying again but ... what _is_ > the formatting rule? Searching in controls: > > - wildcard search: `` = 1000+ vs. `` = 379 > - verbatim: `` = 173 vs. `` =

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-22 Thread Jeanette Winzenburg
On Fri, 22 Oct 2021 09:45:10 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java >> line 548: >> >>> 546: int editingRow = 1; >>> 547: cell.updateIndex(editingRow); >>> 548: TablePosition editingCell =

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-22 Thread Jeanette Winzenburg
On Thu, 21 Oct 2021 18:50:45 GMT, Marius Hanl wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed formatting as suggested in review >> >> and removed unused (by this fix) import in same file > >

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-21 Thread Marius Hanl
On Fri, 15 Oct 2021 10:21:12 GMT, Jeanette Winzenburg wrote: >> cell startEdit is supposed to update the editing location on its associated >> control - was done in ListCell, not in Tree-/TableCell nor TreeCell. >> >> Fix was to add control.edit(..). Note that ListCell was also touched to use

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-15 Thread Jeanette Winzenburg
On Wed, 13 Oct 2021 21:25:43 GMT, Marius Hanl wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed formatting as suggested in review >> >> and removed unused (by this fix) import in same file > >

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v2]

2021-10-15 Thread Jeanette Winzenburg
> cell startEdit is supposed to update the editing location on its associated > control - was done in ListCell, not in Tree-/TableCell nor TreeCell. > > Fix was to add control.edit(..). Note that ListCell was also touched to use > the exact same method call pattern as the fixed cell types. > >