Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Jeanette Winzenburg
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added

Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Jeanette Winzenburg
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added

Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Ambarish Rapte
On Wed, 5 May 2021 09:32:30 GMT, Ambarish Rapte wrote: > We have couple more similar issues reported > > 1. [JDK-8255935](https://bugs.openjdk.java.net/browse/JDK-8255935) : > MultipleSelectionModel provides incorrect 'removed' sub-list in change events > 2.

Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]

2021-05-10 Thread Ambarish Rapte
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added