Re: RFR: 8217472: Add attenuation for PointLight [v15]

2020-10-09 Thread Kevin Rushforth
On Fri, 9 Oct 2020 14:55:36 GMT, Nir Lisker wrote: >> tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java >> line 135: >> >>> 133: @AfterClass >>> 134: public static void teardown() { >>> 135: Platform.runLater(() -> { >> >> I forgot to

Re: RFR: 8217472: Add attenuation for PointLight [v15]

2020-10-09 Thread Nir Lisker
On Fri, 9 Oct 2020 12:34:08 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java >

Re: RFR: 8217472: Add attenuation for PointLight [v15]

2020-10-09 Thread Kevin Rushforth
On Fri, 9 Oct 2020 04:53:36 GMT, Nir Lisker wrote: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review comments

Re: RFR: 8217472: Add attenuation for PointLight [v15]

2020-10-08 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: