Re: [Integrated] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-06 Thread Kevin Rushforth
Changeset: 286d1b54 Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-11-06 12:43:43 + URL: https://git.openjdk.java.net/jfx/commit/286d1b54 8230492: font-family not set in HTMLEditor if font name has a number in it Reviewed-by: kcr, shadzic !

Re: [Rev 01] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-06 Thread Hadzic Samir
On Tue, 5 Nov 2019 11:17:55 GMT, Arun Joseph wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - afc7f17a: Minor formatting > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/27/files > - new:

Re: [Rev 01] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-05 Thread Arun Joseph
The pull request has been updated with additional changes. Added commits: - afc7f17a: Minor formatting Changes: - all: https://git.openjdk.java.net/jfx/pull/27/files - new: https://git.openjdk.java.net/jfx/pull/27/files/5a1fbade..afc7f17a Webrevs: - full:

Re: [Approved] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-05 Thread Kevin Rushforth
On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph wrote: > In the HTMLEditor, when positioning the caret in a text and trying to set a > font-family that has a number in it is not working. > > Issue: In >

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-05 Thread Kevin Rushforth
On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph wrote: > In the HTMLEditor, when positioning the caret in a text and trying to set a > font-family that has a number in it is not working. > > Issue: In >

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-04 Thread Arun Joseph
On Wed, 30 Oct 2019 13:27:32 GMT, Kevin Rushforth wrote: > On Wed, 30 Oct 2019 11:09:38 GMT, Hadzic Samir wrote: > >> On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph >> wrote: >> >>> In the HTMLEditor, when positioning the caret in a text and trying to set a >>> font-family that has a number

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-10-30 Thread Kevin Rushforth
On Wed, 30 Oct 2019 11:09:38 GMT, Hadzic Samir wrote: > On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph > wrote: > >> In the HTMLEditor, when positioning the caret in a text and trying to set a >> font-family that has a number in it is not working. >> >> Issue: In >>

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-10-30 Thread Hadzic Samir
On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph wrote: > In the HTMLEditor, when positioning the caret in a text and trying to set a > font-family that has a number in it is not working. > > Issue: In >

RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-10-30 Thread Arun Joseph
In the HTMLEditor, when positioning the caret in a text and trying to set a font-family that has a number in it is not working. Issue: In [CSSPropertyParser.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSPropertyParser.cpp),