Re: [Integrated] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-23 Thread Arunprasad Rajkumar
Changeset: ab6ea3b9 Author:Arunprasad Rajkumar Date: 2019-10-23 08:41:40 + URL: https://git.openjdk.java.net/jfx/commit/ab6ea3b9 8232158: [macOS] Fallback to command line tools if xcode is missing Reviewed-by: kcr, jvos ! buildSrc/mac.gradle

Re: [Approved] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-23 Thread Johan Vos
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missing > > Changes: https://git.openjdk.java.

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-22 Thread Arunprasad Rajkumar
On Wed, 16 Oct 2019 15:54:54 GMT, Arunprasad Rajkumar wrote: > On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > >> On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar >> wrote: >> >>> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >>> wrote: >>> 8232158: [macOS] F

Re: [Approved] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-21 Thread Kevin Rushforth
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missing > > Changes: https://git.openjdk.java.

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-16 Thread Arunprasad Rajkumar
On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >> wrote: >> >>> 8232158: [macOS] Fallback to command line tools if xcode is missing >>> >>>

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-16 Thread Kevin Rushforth
On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar wrote: > On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar > wrote: > >> 8232158: [macOS] Fallback to command line tools if xcode is missing >> >> >> >> Commits: >> - 063d2f38: JDK-8232158: [macOS] Fallback to comma

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-16 Thread Arunprasad Rajkumar
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missing > > Changes: https://git.openjdk.java.

Re: [Rev 01] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-10 Thread Arunprasad Rajkumar
The pull request has been updated with additional changes. Added commits: - 9b1f7286: 8232158: [macOS] Fallback to command line tools if xcode is missing Changes: - all: https://git.openjdk.java.net/jfx/pull/13/files - new: https://git.openjdk.java.net/jfx/pull/13/files/063

RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-10 Thread Arunprasad Rajkumar
8232158: [macOS] Fallback to command line tools if xcode is missing Commits: - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is missing Changes: https://git.openjdk.java.net/jfx/pull/13/files Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00