Re: [Integrated] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-16 Thread Ambarish Rapte
Changeset: 4f496d41 Author:Ambarish Rapte Date: 2019-11-16 16:07:10 + URL: https://git.openjdk.java.net/jfx/commit/4f496d41 8234194: [TEST_BUG] Reenable few graphics unit tests Reviewed-by: kcr !

Re: [Approved] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-16 Thread Ambarish Rapte
On Fri, 15 Nov 2019 22:38:56 GMT, Kevin Rushforth wrote: > On Fri, 15 Nov 2019 10:33:16 GMT, Ambarish Rapte wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e7856f6e: reenable some more tests and fix review comment >>

Re: [Approved] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-15 Thread Kevin Rushforth
On Fri, 15 Nov 2019 10:33:16 GMT, Ambarish Rapte wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e7856f6e: reenable some more tests and fix review comment > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/39/files >

Re: RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-15 Thread Ambarish Rapte
On Fri, 15 Nov 2019 10:34:58 GMT, Ambarish Rapte wrote: > On Thu, 14 Nov 2019 23:55:45 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 19:56:16 GMT, Ambarish Rapte wrote: >> >>> Following graphics unit tests can be re-enabled. >>> >>> 1. >>>

Re: [Rev 01] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-15 Thread Ambarish Rapte
The pull request has been updated with additional changes. Added commits: - e7856f6e: reenable some more tests and fix review comment Changes: - all: https://git.openjdk.java.net/jfx/pull/39/files - new: https://git.openjdk.java.net/jfx/pull/39/files/5df00884..e7856f6e

Re: RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 19:56:16 GMT, Ambarish Rapte wrote: > Following graphics unit tests can be re-enabled. > > 1. > test.com.sun.javafx.scene.layout.region.BackgroundRepeatConverterTest.scenario2 > RepeatStructConverter.convert() is an internal method and does not verify the > parameters.

RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-14 Thread Ambarish Rapte
Following graphics unit tests can be re-enabled. 1. test.com.sun.javafx.scene.layout.region.BackgroundRepeatConverterTest.scenario2 RepeatStructConverter.convert() is an internal method and does not verify the parameters. Passing null value to this method results in NPE. 2.