On Fri, 11 Jun 2021 12:54:43 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.cc line 50:
>
>> 48:
>> 49:
On Fri, 11 Jun 2021 01:30:27 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
On Fri, 11 Jun 2021 01:30:27 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
> Added a SpotLight only to the D3D pipeline currently.
>
> ### API discussion points
>
> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also
> be a subclass of `PointLight` as it's a point light with direction and extra
> factors. I saw that `scenario.effect.light.Spo