Re: [Integrated] RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-29 Thread Kevin Rushforth
Changeset: aa6f3a4e Author:Robert Lichtenberger Committer: Kevin Rushforth Date: 2020-01-27 13:43:47 + URL: https://git.openjdk.java.net/jfx/commit/aa6f3a4e 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 Reviewed-by: ghb, kcr !

Re: [Integrated] RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-27 Thread Kevin Rushforth
Changeset: aa6f3a4e Author:Robert Lichtenberger Committer: Kevin Rushforth Date: 2020-01-27 13:43:47 + URL: https://git.openjdk.java.net/jfx/commit/aa6f3a4e 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 Reviewed-by: ghb, kcr !

Re: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-14 Thread Robert Lichtenberger
How strange: Other commits to the master branch of my forked repository (relating to another issue, already integrated into OpenJFX) are also showing up here. But the change really only consists of 542ff60e which contains the fix for JDK-8236912. My older contributions were not checked into a

Re: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-14 Thread Kevin Rushforth
On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger wrote: > As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two

RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-14 Thread Robert Lichtenberger
As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works