Changeset: aa91ebbb
Author:Guru Hb
Date: 2020-02-03 08:51:25 +
URL: https://git.openjdk.java.net/jfx/commit/aa91ebbb
8237944: webview native cl "-m32" unknown option for windows 32-bit build
Reviewed-by: kcr
! modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm
On Wed, 29 Jan 2020 15:36:52 GMT, Guru Hb wrote:
>> Marked as reviewed by kcr (Lead).
>
>> the -m32 option seems to be ignored by the compiler:
>> cl : Command line warning D9002 : ignoring unknown option '-m32'
>>
>> However, I agree it is better to conditionally remove it.
> "-m32" required
On Wed, 29 Jan 2020 12:57:41 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> Marked as reviewed by kcr (Lead).
> the -m32 option seems to be ignored by the compiler:
> cl : Command line warning D9002 : ignoring unknown option '-m32'
>
> However,
On Wed, 29 Jan 2020 12:58:00 GMT, Guru Hb wrote:
>> cl : Command line warning D9002 : ignoring unknown option '-m32'
>>
>> post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of
>> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
>> '-m32' flag is
> cl : Command line warning D9002 : ignoring unknown option '-m32'
>
> post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of
> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
> '-m32' flag is gcc specifc and on windows cl.exe (visual studio)
On Tue, 28 Jan 2020 09:50:27 GMT, Guru Hb wrote:
> cl : Command line warning D9002 : ignoring unknown option '-m32'
>
> post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of
> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
> '-m32' flag is gcc
On Tue, 28 Jan 2020 21:03:01 GMT, Johan Vos wrote:
>> cl : Command line warning D9002 : ignoring unknown option '-m32'
>>
>> post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of
>> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
>> '-m32' flag
On Tue, 28 Jan 2020 09:50:27 GMT, Guru Hb wrote:
> cl : Command line warning D9002 : ignoring unknown option '-m32'
>
> post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of
> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
> '-m32' flag is gcc
cl : Command line warning D9002 : ignoring unknown option '-m32'
post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of
cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
'-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't
