On Sat, 8 May 2021 15:41:06 GMT, Kevin Rushforth wrote:
> This is a mostly-clean backport to jfx11u. The only merge conflicts I had to
> fix were in `D3DPipeline.cc` to ignore two hunks from the patch, since the
> static library support is not present in 11 (this is the exact same thing I
> ha
This is a mostly-clean backport to jfx11u. The only merge conflicts I had to
fix were in `D3DPipeline.cc` to ignore two hunks from the patch, since the
static library support is not present in 11 (this is the exact same thing I had
to do for the FX 8u backport).
Tested on all three platforms, a
On Tue, 23 Mar 2021 20:06:15 GMT, Oliver Schmidtmer
wrote:
>> @Schmidor did you have any further comments or feedback?
>>
>> Btw, I realized that you don't have a role in the openjfx project, so you
>> can't formally review it. As such, I'll change the requirements back to 2
>> reviewers. I'l
On Tue, 23 Mar 2021 19:17:20 GMT, Kevin Rushforth wrote:
>> Fix looks good. Tested WebView by reconnecting via remote desktop.
>
> @Schmidor did you have any further comments or feedback?
>
> Btw, I realized that you don't have a role in the openjfx project, so you
> can't formally review it. A
On Tue, 23 Mar 2021 17:36:28 GMT, Arun Joseph wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments to fix typo in comment
>
> Fix looks good. Tested WebView by reconnecting via remote desktop.
On Sat, 20 Mar 2021 13:40:51 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
On Sat, 20 Mar 2021 13:40:51 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
> This is a fix for a long-standing bug where the D3D pipeline will stop
> rendering when a Windows remote desktop session is disconnected and then
> reconnected.
>
> A preliminary Draft PR #315 by @Schmidor was a good first step in solving
> this. I took that and continued the work in my Draft
On Fri, 19 Mar 2021 08:22:06 GMT, Ambarish Rapte wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor typos + make verbose print less verbose
>
> The fix and Sanity testing looks all good.
> I shall need some m
On Fri, 19 Mar 2021 12:08:04 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
On Fri, 19 Mar 2021 08:17:56 GMT, Ambarish Rapte wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor typos + make verbose print less verbose
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/RTI
> This is a fix for a long-standing bug where the D3D pipeline will stop
> rendering when a Windows remote desktop session is disconnected and then
> reconnected.
>
> A preliminary Draft PR #315 by @Schmidor was a good first step in solving
> this. I took that and continued the work in my Draft
On Thu, 18 Mar 2021 21:13:55 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
On Thu, 18 Mar 2021 22:08:29 GMT, Oliver Schmidtmer
wrote:
>> I did a pass over the review and left a few inline comments pointing out
>> minor changes that I plan to make (in print statements and comments).
>
> I can confirm the reinitialization after RDP reconnect works for me,
> standalone
On Thu, 18 Mar 2021 15:30:13 GMT, Kevin Rushforth wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> co
> This is a fix for a long-standing bug where the D3D pipeline will stop
> rendering when a Windows remote desktop session is disconnected and then
> reconnected.
>
> A preliminary Draft PR #315 by @Schmidor was a good first step in solving
> this. I took that and continued the work in my Draft
On Wed, 17 Mar 2021 20:47:09 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
> This is a fix for a long-standing bug where the D3D pipeline will stop
> rendering when a Windows remote desktop session is disconnected and then
> reconnected.
>
> A preliminary Draft PR #315 by @Schmidor was a good first step in solving
> this. I took that and continued the work in my Draft
On Wed, 17 Mar 2021 18:23:07 GMT, Kevin Rushforth wrote:
>> This is a fix for a long-standing bug where the D3D pipeline will stop
>> rendering when a Windows remote desktop session is disconnected and then
>> reconnected.
>>
>> A preliminary Draft PR #315 by @Schmidor was a good first step in
On Tue, 16 Feb 2021 15:42:51 GMT, Kevin Rushforth wrote:
>> This is a good starting point, but it will need additional work, possibly in
>> the native D3D code as well as on the Java side, to fully cleanup and
>> recreate all of the resources after the device is recreated. As discussed
>> offl
This is a fix for a long-standing bug where the D3D pipeline will stop
rendering when a Windows remote desktop session is disconnected and then
reconnected.
A preliminary Draft PR #315 by @Schmidor was a good first step in solving this.
I took that and continued the work in my Draft PR #403. It
On Wed, 17 Mar 2021 18:17:48 GMT, Kevin Rushforth wrote:
> This is a fix for a long-standing bug where the D3D pipeline will stop
> rendering when a Windows remote desktop session is disconnected and then
> reconnected.
>
> A preliminary Draft PR #315 by @Schmidor was a good first step in solv
On Thu, 11 Feb 2021 00:17:10 GMT, Kevin Rushforth wrote:
>> I moved it to Draft before noticing that there were additional commits after
>> your last comment that I had missed seeing earlier, so I moved it back to
>> RFR.
>
> This is a good starting point, but it will need additional work, poss
On Mon, 11 Jan 2021 22:20:38 GMT, Kevin Rushforth wrote:
>> Now more of my company are remoting into machines this issue is causing
>> problems for us.
>
> I moved it to Draft before noticing that there were additional commits after
> your last comment that I had missed seeing earlier, so I mov
On Thu, 26 Nov 2020 09:38:22 GMT, Christopher Hewett
wrote:
>> On a side note, not all resources seem to be freed / recreated on pipeline
>> disposal. There are some error outputs, and some parts in a webview are only
>> rendered after interactions. So it is probably better to mark this as WIP
On Tue, 13 Oct 2020 16:40:45 GMT, Oliver Schmidtmer
wrote:
>> I hope I understood your intend. I've tried to replace the recreation of the
>> GraphicsPipeline-Instance by only calling the native parts. Unfortunately
>> that doesn't seem to work at all. Probably I'm missing some updates.
>>
> When connecting via Remote Desktop to a Windows 10 machine ans starting a
> JavaFX application, the D3D pipeline is used successfully.
> After closing the the Remote Desktop session and reconnecting, the D3D
> requests fail with an D3DERR_DEVICEREMOVED HResult, and the application
> contents
On Fri, 9 Oct 2020 23:17:27 GMT, Kevin Rushforth wrote:
>> The full recreation of the pipeline is only done when D3DERR_DEVICEREMOVED
>> is occurring. On other causes of why the
>> device is not ready, only the factory reference in the painter is cleared.
>
>> The full recreation of the pipeline
On Thu, 8 Oct 2020 16:33:55 GMT, Oliver Schmidtmer
wrote:
> The full recreation of the pipeline is only done when D3DERR_DEVICEREMOVED is
> occurring
I see that now. That part is fine then.
Another concern is that this would be the first time we have recreated a
GraphicsPipeline -- they are
On Thu, 8 Oct 2020 16:19:52 GMT, Kevin Rushforth wrote:
>> When connecting via Remote Desktop to a Windows 10 machine ans starting a
>> JavaFX application, the D3D pipeline is used
>> successfully. After closing the the Remote Desktop session and reconnecting,
>> the D3D requests fail with an
>
On Thu, 8 Oct 2020 16:07:08 GMT, Oliver Schmidtmer
wrote:
> When connecting via Remote Desktop to a Windows 10 machine ans starting a
> JavaFX application, the D3D pipeline is used
> successfully. After closing the the Remote Desktop session and reconnecting,
> the D3D requests fail with an
>
When connecting via Remote Desktop to a Windows 10 machine ans starting a
JavaFX application, the D3D pipeline is used
successfully. After closing the the Remote Desktop session and reconnecting,
the D3D requests fail with an
D3DERR_DEVICEREMOVED HResult, and the application contents are not ren
32 matches
Mail list logo
