Re: [Integrated] RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Kevin Rushforth
Changeset: cf0bba62 Author:Arun Joseph Committer: Kevin Rushforth Date: 2020-03-05 19:28:25 + URL: https://git.openjdk.java.net/jfx/commit/cf0bba62 8240211: Stack overflow on Windows 32-bit can lead to crash Reviewed-by: ghb, kcr, jvos ! modules/javafx.web/src/main/native/So

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Johan Vos
On Thu, 5 Mar 2020 14:51:03 GMT, Arun Joseph wrote: > Issue: The stack pointer is checked close to the stack limit during the last > iteration of calling frameLoaded() and then, grows beyond the thread's stack > range causing a stack overflow and crashes. This occurs as the stack grows by > an

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Kevin Rushforth
On Thu, 5 Mar 2020 14:51:03 GMT, Arun Joseph wrote: > Issue: The stack pointer is checked close to the stack limit during the last > iteration of calling frameLoaded() and then, grows beyond the thread's stack > range causing a stack overflow and crashes. This occurs as the stack grows by > an

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Kevin Rushforth
On Thu, 5 Mar 2020 17:46:17 GMT, Johan Vos wrote: >> Looks good to me. >> I believe you have executed DRT on both 64 & 32 bit build. > > This looks correct and very valuable to me. Would be great if there was a > test that results in a crash before? Here is a pointer to the [apply-style-ifram

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Johan Vos
On Thu, 5 Mar 2020 16:50:55 GMT, Guru Hb wrote: >> Issue: The stack pointer is checked close to the stack limit during the last >> iteration of calling frameLoaded() and then, grows beyond the thread's stack >> range causing a stack overflow and crashes. This occurs as the stack grows >> by an

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Guru Hb
On Thu, 5 Mar 2020 14:51:03 GMT, Arun Joseph wrote: > Issue: The stack pointer is checked close to the stack limit during the last > iteration of calling frameLoaded() and then, grows beyond the thread's stack > range causing a stack overflow and crashes. This occurs as the stack grows by > an

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Kevin Rushforth
On Thu, 5 Mar 2020 14:51:03 GMT, Arun Joseph wrote: > Issue: The stack pointer is checked close to the stack limit during the last > iteration of calling frameLoaded() and then, grows beyond the thread's stack > range causing a stack overflow and crashes. This occurs as the stack grows by > an

RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

2020-03-05 Thread Arun Joseph
Issue: The stack pointer is checked close to the stack limit during the last iteration of calling frameLoaded() and then, grows beyond the thread's stack range causing a stack overflow and crashes. This occurs as the stack grows by an amount larger than the reserved zone at the end of the stack.