Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-12 Thread Arun Joseph
On Mon, 12 Oct 2020 13:42:08 GMT, Kevin Rushforth wrote: >> Instead of negation, it should have been at the opposite positions. I have >> fixed this in the latest commit. The arg >> list order for >>

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-12 Thread Kevin Rushforth
On Mon, 12 Oct 2020 03:23:29 GMT, Arun Joseph wrote: >> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java >> line 790: >> >>> 788: Affine3D at = new Affine3D(); >>> 789: at.translate(phase.getX(), phase.getY()); >>>

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-11 Thread Arun Joseph
On Fri, 9 Oct 2020 22:14:15 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright year >> - Minor refactoring > >

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-11 Thread Arun Joseph
On Fri, 9 Oct 2020 21:48:40 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright year >> - Minor refactoring > >

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-10-09 Thread Kevin Rushforth
On Mon, 24 Aug 2020 07:48:27 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() for

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]

2020-08-24 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't