Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-06 Thread Ambarish Rapte
On Mon, 12 Oct 2020 03:11:18 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern()

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-05 Thread Kevin Rushforth
On Wed, 4 Nov 2020 15:41:12 GMT, Arun Joseph wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/PaintHelper.java >> line 754: >> >>> 752: >>> 753: BaseTransform paintXform = paint.getPatternTransformNoClone(); >>> 754: if (paintXform != null) { >> >> Minor:

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-04 Thread Arun Joseph
On Tue, 3 Nov 2020 12:01:38 GMT, Ambarish Rapte wrote: >> Arun Joseph has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix incorrect concat param order > > modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/PaintHelper.java >

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-03 Thread Ambarish Rapte
On Mon, 12 Oct 2020 03:11:18 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern()

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-10-12 Thread Kevin Rushforth
On Mon, 12 Oct 2020 03:11:18 GMT, Arun Joseph wrote: >> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() for

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-10-11 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't