Re: RFR: 8244297: memory leak test utility [v6]

2020-10-17 Thread Kevin Rushforth
On Sat, 17 Oct 2020 14:02:39 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8244297 >> Fixed unit-test > > This is looking quite good now. I really like how it simplifies the tests

Re: RFR: 8244297: memory leak test utility [v6]

2020-10-17 Thread Kevin Rushforth
On Thu, 8 Oct 2020 06:46:21 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8244297 >> Fixed unit-test > > modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line

Re: RFR: 8244297: memory leak test utility [v6]

2020-10-17 Thread Kevin Rushforth
On Sat, 3 Oct 2020 16:00:48 GMT, Florian Kirmaier wrote: >> It's based on the discussion of my previous PR: >> https://github.com/openjdk/jfx/pull/71 >> >> I Added test utility class copied from JMemoryBuddy and used it to simplify >> 4 of the existing unit tests. >> >> It's a direct copy of

Re: RFR: 8244297: memory leak test utility [v6]

2020-10-17 Thread Kevin Rushforth
On Fri, 16 Oct 2020 14:08:53 GMT, Florian Kirmaier wrote: >> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 84: >> >>> 82: >>> 83: /** >>> 84: * Checks whether the content of the WeakReference can be collected. >> >> -> Checks whether the content of the

Re: RFR: 8244297: memory leak test utility [v6]

2020-10-16 Thread Florian Kirmaier
On Thu, 8 Oct 2020 07:50:02 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8244297 >> Fixed unit-test > > modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line

Re: RFR: 8244297: memory leak test utility [v6]

2020-10-16 Thread Florian Kirmaier
On Thu, 8 Oct 2020 07:47:33 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8244297 >> Fixed unit-test > > modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line

Re: RFR: 8244297: memory leak test utility [v6]

2020-10-08 Thread Ambarish Rapte
On Sat, 3 Oct 2020 16:00:48 GMT, Florian Kirmaier wrote: >> It's based on the discussion of my previous PR: >> https://github.com/openjdk/jfx/pull/71 >> >> I Added test utility class copied from JMemoryBuddy and used it to simplify >> 4 of the existing unit tests. >> >> It's a direct copy of

Re: RFR: 8244297: memory leak test utility [v6]

2020-10-03 Thread Florian Kirmaier
> It's based on the discussion of my previous PR: > https://github.com/openjdk/jfx/pull/71 > > I Added test utility class copied from JMemoryBuddy and used it to simplify 4 > of the existing unit tests. > > It's a direct copy of my project >