Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Johan Vos
On Fri, 2 Jul 2021 18:29:40 GMT, Phil Race wrote: >> When you say "public" you mean in the lists that the implementation searches >> for a match ? >> This could get tricky. I don't have a complete answer off the top of my head. >> Could we at least filter the returned list of full and family nam

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Phil Race
On Fri, 2 Jul 2021 18:29:12 GMT, Phil Race wrote: >> They are in there. But with the current approach for CT glyph-parsing, I see >> no other way. The parsing is done in native code (e.g. >> OS.CTLineCreateWithAttributedString()) but we extract the required font from >> the returned runs, e.g.

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Phil Race
On Fri, 2 Jul 2021 12:34:32 GMT, Johan Vos wrote: >> Another thought .. after doing this do these "." fonts appear in the list of >> fonts reported by >> javafx.scene.text.Font.getFontNames() ? >> >> I suspect they really should not .. > > They are in there. But with the current approach for CT

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-02 Thread Johan Vos
On Thu, 1 Jul 2021 22:21:52 GMT, Phil Race wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/font/MacFontFinder.java >> line 83: >> >>> 81: Stream stream = >>> Files.list(Paths.get("/System/Library/Fonts")); >>> 82: stream.forEach(f -> >>> PrismFontFactory

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-01 Thread Phil Race
On Thu, 1 Jul 2021 20:53:36 GMT, Phil Race wrote: >> [Mac only] register system fonts. >> Fix for JDK-8246104 >> >> The list of available fonts returned by >> CTFontCollectionCreateFromAvailableFonts does not contain internal fonts (at >> least not by default, although this is not documented).

Re: RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-07-01 Thread Phil Race
On Sat, 26 Jun 2021 15:40:47 GMT, Johan Vos wrote: > [Mac only] register system fonts. > Fix for JDK-8246104 > > The list of available fonts returned by > CTFontCollectionCreateFromAvailableFonts does not contain internal fonts (at > least not by default, although this is not documented). By r

RFR: 8246104: Some complex text doesn't render correctly on macOS

2021-06-26 Thread Johan Vos
[Mac only] register system fonts. Fix for JDK-8246104 The list of available fonts returned by CTFontCollectionCreateFromAvailableFonts does not contain internal fonts (at least not by default, although this is not documented). By registering font(s) (files), those fonts become available in the