On Thu, 13 Aug 2020 19:45:49 GMT, Florian Kirmaier
wrote:
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>>
>> This small change fixing the minimize for mac.
>> Changes are property registered.
>> Calling setIconize(true) no longer resets to false.
>
> Florian Kirmaier has updated
On Thu, 13 Aug 2020 12:52:37 GMT, Florian Kirmaier
wrote:
>>> JDK-8251241: macOS: iconify property doesn't change after minimize when
>>> resizable is false ⚠️ Title mismatch between PR
>>> and JBS.
>>
>> Can you change the title to match the JBS title?
>
> Done! I've changed the title.
On Thu, 13 Aug 2020 20:29:47 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8251241
>> applied tests from kevinrushforth
>
> Looks good. Thanks for fixing this long-standing bug.
>
> I
On Thu, 13 Aug 2020 19:45:49 GMT, Florian Kirmaier
wrote:
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>>
>> This small change fixing the minimize for mac.
>> Changes are property registered.
>> Calling setIconize(true) no longer resets to false.
>
> Florian Kirmaier has updated
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the
On Thu, 13 Aug 2020 19:21:56 GMT, Kevin Rushforth wrote:
>> You may have seen my comment in JBS: This PR also fixes
>> [JDK-8249202](https://bugs.openjdk.java.net/browse/JDK-8249202), which I
>> discovered while testing
>> [JDK-8248490](https://bugs.openjdk.java.net/browse/JDK-8248490). This
On Thu, 13 Aug 2020 18:11:25 GMT, Kevin Rushforth wrote:
>> Thank you for the very quick feedback!
>> In the application, the fix was developed for, it also seems to fix all
>> issues related to iconified.
>
> You may have seen my comment in JBS: This PR also fixes
>
On Thu, 13 Aug 2020 17:09:43 GMT, Florian Kirmaier
wrote:
>> This looks good based on my initial testing, including a modified version of
>> the test program that doesn't temporarily
>> set resizable to true. Nice.
>> I want to do some additional testing.
>>
>> I left one minor comment on the
On Thu, 13 Aug 2020 16:35:51 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8251241
>> Added missing spaces to match the coding style.
>
>
On Thu, 13 Aug 2020 16:37:44 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8251241
>> Added missing spaces to match the coding style.
>
> This looks good based on my initial
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the
On Thu, 13 Aug 2020 12:37:11 GMT, Florian Kirmaier
wrote:
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
This looks good based on my initial
On Thu, 13 Aug 2020 12:47:32 GMT, Kevin Rushforth wrote:
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>>
>> This small change fixing the minimize for mac.
>> Changes are property registered.
>> Calling setIconize(true) no longer resets to false.
>
>> JDK-8251241: macOS: iconify
13 matches
Mail list logo
