Re: RFR: 8252935: Add treeShowing listener only when needed [v2]

2021-01-24 Thread Jeanette Winzenburg
On Sun, 24 Jan 2021 09:24:56 GMT, John Hendrikx wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ProgressIndicatorSkin.java >> line 239: >> >>> 237: super.dispose(); >>> 238: >>> 239: treeShowingExpression.dispose(); >> >> This could be removed if you

Re: RFR: 8252935: Add treeShowing listener only when needed [v2]

2021-01-24 Thread John Hendrikx
On Fri, 22 Jan 2021 21:31:42 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> WIP: Moved treeShowingProperty into its own class > >

Re: RFR: 8252935: Add treeShowing listener only when needed [v2]

2021-01-24 Thread John Hendrikx
On Fri, 22 Jan 2021 21:32:28 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> WIP: Moved treeShowingProperty into its own class > >

Re: RFR: 8252935: Add treeShowing listener only when needed [v2]

2021-01-24 Thread John Hendrikx
On Fri, 22 Jan 2021 21:36:53 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> WIP: Moved treeShowingProperty into its own class > > I left a few inline comments

Re: RFR: 8252935: Add treeShowing listener only when needed [v2]

2021-01-24 Thread John Hendrikx
> This is a PoC for performance testing. > > It contains commented out code in PopupWindow and ProgressIndicatorSkin and > two tests are failing because of that. > > This code avoids registering two listeners (on Scene and on Window) for each > and every Node to support the aforementioned