On Mon, 1 Feb 2021 04:41:20 GMT, John Hendrikx wrote:
>> The updated fix using `registerChangeListener` and the test look good. I
>> left a few mostly-minor comments.
>
> I think this change is complete now, including an integration test and tests
> on all new code. Please let me know if
On Thu, 28 Jan 2021 13:37:59 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add performance test
>> - Use registerChangeListener in ProgressIndicatorSkin
>
> The updated fix using
On Sun, 24 Jan 2021 15:25:06 GMT, John Hendrikx wrote:
>> This is a PoC for performance testing.
>>
>> It contains commented out code in PopupWindow and ProgressIndicatorSkin and
>> two tests are failing because of that.
>>
>> This code avoids registering two listeners (on Scene and on
On Sun, 24 Jan 2021 09:02:17 GMT, John Hendrikx wrote:
>> I left a few inline comments below.
>
> Sorry about the force push, merging over a year of changes from master did
> not seem right to me. It was only for getting up to date, I will do the
> other commits normally.
> 1. Merge in the
> This is a PoC for performance testing.
>
> It contains commented out code in PopupWindow and ProgressIndicatorSkin and
> two tests are failing because of that.
>
> This code avoids registering two listeners (on Scene and on Window) for each
> and every Node to support the aforementioned
